fix: y and n are invalid selections in KlipperFlashOverviewMenu #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
Signed-off-by: Dominik Willner <th33xitus@gmail.com>
DicyRoll
added a commit
to DicyRoll/kiauh
that referenced
this pull request
Sep 11, 2024
commit 4cf523a Merge: 1d06bf7 694a4c2 Author: dw-0 <th33xitus@gmail.com> Date: Sun Sep 8 19:04:19 2024 +0200 Merge pull request dw-0#524 from dw-0/develop Merge develop into master commit 694a4c2 Author: dw-0 <th33xitus@gmail.com> Date: Sun Sep 8 18:58:07 2024 +0200 fix: typo in "origin" and "managed_services" (dw-0#520) * fix: typo in "origin" and "managed_services" for klipperscreen update manager config Signed-off-by: Dominik Willner <th33xitus@gmail.com> * fix: typo in "origin" for moonraker telegram bot update manager config Signed-off-by: Dominik Willner <th33xitus@gmail.com> --------- Signed-off-by: Dominik Willner <th33xitus@gmail.com> commit a54514c Author: dw-0 <th33xitus@gmail.com> Date: Thu Sep 5 20:31:38 2024 +0200 fix: fix switching of repositories (dw-0#519) * fix: fix repo switching Extend the functionality of repo switching by creating a backup before the switch. Also implement a rollback mechanic in case of an error. Signed-off-by: Dominik Willner <th33xitus@gmail.com> * refactor: fail when installing requirements fails Signed-off-by: Dominik Willner <th33xitus@gmail.com> * refactor: display owner and repo in main menu on separate lines long owner and repo names would case the menu to be too wide Signed-off-by: Dominik Willner <th33xitus@gmail.com> --------- Signed-off-by: Dominik Willner <th33xitus@gmail.com> commit 1d06bf7 Merge: 0ee0fa3 e438081 Author: dw-0 <th33xitus@gmail.com> Date: Sun Sep 1 19:02:48 2024 +0200 Merge pull request dw-0#511 from dw-0/develop Merge develop into master commit e438081 Author: dw-0 <th33xitus@gmail.com> Date: Sun Sep 1 18:51:25 2024 +0200 fix: update SimpleConfigParser submodule (dw-0#510) commit 9f50f6f Author: dw-0 <th33xitus@gmail.com> Date: Sun Sep 1 18:31:15 2024 +0200 fix: y and n are invalid selections in KlipperFlashOverviewMenu (dw-0#508) Signed-off-by: Dominik Willner <th33xitus@gmail.com> commit 0ee0fa3 Author: dw-0 <th33xitus@gmail.com> Date: Sat Aug 31 19:16:52 2024 +0200 feat: KIAUH v6 - full rewrite of KIAUH in Python (dw-0#428) commit 8547942 Author: Henrik Fransson <hmf.hmf.hmf@gmail.com> Date: Tue Aug 6 16:41:18 2024 +0200 readme: fix broken OctoApp plugin link (dw-0#494) commit d33ac6b Author: dw-0 <th33xitus@gmail.com> Date: Sat Aug 3 13:30:34 2024 +0200 fix: parse moonraker dependencies from system-dependencies.json (dw-0#492) Signed-off-by: Dominik Willner <th33xitus@gmail.com> commit 6cd9133 Author: dw-0 <th33xitus@gmail.com> Date: Wed Jul 31 20:30:33 2024 +0200 fix: detect RatOS 2.1+ as operating system and exit (dw-0#490) Signed-off-by: Dominik Willner <th33xitus@gmail.com> commit a929c69 Author: Beans Baxter <24848012+BeansIsFat@users.noreply.github.com> Date: Fri Jun 28 17:07:20 2024 -0400 refactor: don't check spoolman version if not installed (dw-0#487) commit bce9200 Author: breakheart <llllg324@gmail.com> Date: Fri Jun 28 23:46:19 2024 +0800 fix: use correct Spoolman directory name (dw-0#486) commit 7993b98 Author: Alessandro Maggi <59124971+DicyRoll@users.noreply.github.com> Date: Wed Jun 26 07:04:09 2024 +0200 fix: replace jq by grep to check Spoolman update (dw-0#482) * fix: remove extra space in remove menu * fix(spoolman): replace jq with grep jq isn't included in some minimal installations commit 62296e1 Author: Alessandro Maggi <59124971+DicyRoll@users.noreply.github.com> Date: Tue Jun 25 20:10:14 2024 +0200 feat: add Spoolman support (dw-0#477) commit a374ac8 Author: Justin Otherguy <justin@justinotherguy.org> Date: Thu May 9 20:56:16 2024 +0200 fix: add unzip to dependencies for Mainsail and Fluidd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #506 and improves some visuals of the various firmware related menus.
Visuals may not be perfect in all cases yet.
Signed-off-by: Dominik Willner th33xitus@gmail.com