This repository has been archived by the owner on May 16, 2019. It is now read-only.
Implement at-pizza #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorah
approved these changes
Apr 19, 2017
|
👍 |
yonex
approved these changes
Apr 19, 2017
|
🍕 |
nanocloudx
approved these changes
Apr 19, 2017
|
🍕 |
ntgaura
approved these changes
Apr 19, 2017
namusyaka
reviewed
Apr 19, 2017
| @@ -77,6 +77,12 @@ export function submitCompose() { | |||
| if (!status || !status.length) { | |||
| return; | |||
| } | |||
|
|
|||
| if (status.match(/\A\s*[@＠]ピザ\s*/) { | |||
There was a problem hiding this comment.
javascript does not support \A in its RegExp, right?
|
|
||
| if (status.match(/\A\s*[@＠]ピザ\s*/) { | ||
| window.open('http://info.nicovideo.jp/pizza/', null); | ||
| return: |
reviewed by @namusyaka and @sorah
|
@namusyaka @sorah Thank you for reviewing |
hiroppy
approved these changes
Apr 19, 2017
|
👍 |
|
|
|
👍 |
|
🍕 |
execjosh
pushed a commit
to execjosh/mastodon
that referenced
this pull request
May 1, 2017
Implement at-pizza
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe @ピザ is a VERY important feature of niconico.
If you feel like it. please merge this.