Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chain_break_fraction kwarg to unembed_response #266

Merged

Conversation

arcondello
Copy link
Member

@arcondello arcondello commented Aug 21, 2018

Closes #246

We do not throw a warning here, that is left to the calling method/composite to do.

@arcondello arcondello added the enhancement New feature or request label Aug 21, 2018
@arcondello arcondello self-assigned this Aug 21, 2018
@codecov-io
Copy link

codecov-io commented Aug 21, 2018

Codecov Report

Merging #266 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   94.35%   94.36%   +0.01%     
==========================================
  Files          31       31              
  Lines        1807     1811       +4     
==========================================
+ Hits         1705     1709       +4     
  Misses        102      102
Impacted Files Coverage Δ
dimod/embedding/transforms.py 96.05% <100%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67f88fd...d931484. Read the comment docs.

Copy link
Member

@randomir randomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Would it make sense to simply always return that broken chains ratio?

@arcondello
Copy link
Member Author

The embedding composites will set it to be true

@arcondello arcondello merged commit 3a35eb4 into dwavesystems:master Aug 22, 2018
@arcondello arcondello deleted the issue246_chain_break_warning branch August 22, 2018 00:07
oneklc pushed a commit to oneklc/dimod that referenced this pull request Apr 6, 2019
…eak_warning

Add chain_break_fraction kwarg to unembed_response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants