Feature/lower bounds #567
Closed
Feature/lower bounds #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lower bounds for the energy of BinaryQuadraticModels.
This code adds two lower bounds: one based on a linear programming relaxation, the other based on a semidefinite programming relaxation. Mathematical details are provided in the code comments.
The LP relaxation uses the python package "mip" and the SDP relaxation uses scipy. However I haven't modified requirements.txt or setup.py, as I'm not sure of the best way to handle these dependencies. The mip package requires python >3.5, so I assume the lower bounds should only be installed optionally. I'd appreciate feedback on this.