Add a simple sampler-tests generating decorator #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2020
arcondello
force-pushed
the
sampler-tests
branch
from
f934aee
to
6d1285b
Compare
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
==========================================
- Coverage 90.81% 90.69% -0.12%
==========================================
Files 57 58 +1
Lines 3918 4018 +100
==========================================
+ Hits 3558 3644 +86
- Misses 360 374 +14
Continue to review full report at Codecov.
|
wbernoudy
approved these changes
Mar 4, 2020
There was a problem hiding this comment.
Great stuff, this will catch many bugs!
Some possible future improvements:
- Allow solver developers to pass in "extra" BQMs to be tested. Maybe for each BQM, convert to each BQM class and vartype.
- We could consider a optional tests that try to ensure the samples returned actually line up with the variable labelling, e.g. pass in a problem with just large hs and check to make sure the samples line up. Obviously this is tricky with heuristics.
|
This covers the labelling and the large problems can be filtered using the |
m3ller
approved these changes
Mar 4, 2020
|
I mean "correct" answers. If I submit h={0: -100, 1: 100}, and get magnetizations of {0: -0.98, 1: 0.99}, the labeling is probably reversed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also fixed some bugs that this testing framework uncovered. There are two bugs remaining to fix but they are significant enough to be beyond the scope of this PR.