bring over lots of Py3 changes from master #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xl.unicode.strxfrm has been removed because it's not needed anymore.
In python2, the alldatadir received via command-line was a byte string, and thus we did a sequence of decode() and encode() to remove any non-ASCII characters. This was necessary because if there were UTF-8 characters in the string, the os.path.join() call threw exception. In python3, the alldatadir is a unicode string, so we need to change the sequence to encode(), followed by decode(). It is also worth noting that os.path.join() does not take issues with UTF-8 characters anymore, so perhaps the whole code block can be removed. But for now, we replace the non-ASCII characters to ? to keep the behavior consistent with the old version...
Python3 file object returns unicode str objects, so GioFileInputStream needs to mimic that behavior...
Use urllib.parse instead of urllib2. Use 'unicode' when converting ETree to string in order to obtain a python3 str object.
Because response.read() returns a byte string.
In both plugins, removed encode('utf-8') calls on artist
and title tag, which converted str to bytes and in turn caused errors
with replace() calls.
Similarly in lyricwiki plugin, the web page content, obtained via
renderContents(), needs to be converted from bytes to str before
subsequent replace() and split() calls.
We were comparing int(m.props.position * track_length) against playback_time, but because the latter was a float, the comparison was never true. So convert the playback_time to int before the comparison to catch the moment when marker is reached. Should fix the segment repeating in A-B repeat plugin.
Prior to this commit, this function would leak file descriptors to PLUGININFO
imp is deprecated. Requires Python 3.6+
This reverts commit c23b4bb.
py3: fix documentation generation on python 3.7+
Fixes #667, this time both on python 3.6 (Ubuntu 18.04) and 3.7 (Fedora 31).
[py3] Several fixes for the plugins module
[py3] Some python 3.x meta stuff
py3: fix documentation generation on python 3.6+ (try 2)
[py3] Fix SyntaxWarnings
Changes: * bump libmodplug soname version to match fedora31, debian8+, ubuntu12.10+ * add logging to give a hint if metadata fetching does not work for the MOD file format
logging.warning() is just the same without deprecation notice.
Python: Replace calls to deprecated logging.warn()
[Py3] Remove a few deprecated functions
Mod format: bump soname version, mention in DEPS, add logging
Currently translated at 100.0% (1068 of 1068 strings)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.