Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks in wrong spot for import folder #4

Open
joshribakoff opened this issue Oct 13, 2013 · 2 comments
Open

Looks in wrong spot for import folder #4

joshribakoff opened this issue Oct 13, 2013 · 2 comments

Comments

@joshribakoff
Copy link

Import location defaults to var/import, and below that it says "No csv files found in /media/Data/mag_17/var/import"

FYI I'm running magento out of /home/josh/www/vehiclefits/magento and magmi is a subfolder inside of that. There is no mag_17 in any path anywhere on my system, confirmed this with recursive globbing on the command line.

@dweeves
Copy link
Owner

dweeves commented Oct 14, 2013

This one is due to my local magmi.conf being in the code repo. i'll remove it asap.

@joshribakoff
Copy link
Author

Thanks. What you could do is create magmi.conf.dist as a "distributed" conf file with reasonable defaults. Then you create a .gitignore in the project root and list "magmi.conf" in it. This tells git to not commit magmi.conf if it exists. You then revise your code to check for magmi.conf, and if not found it checks for magmi.conf.dist.

In this way you provide a "default" conf file that is used, unless the developer copies it & overrides it with their own local settings (and their local file doesn't get committed because its listed in gitignore).

You can see this pattern used in a lot of software from phpmyadmin to phpunit

dweeves pushed a commit that referenced this issue May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants