Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong covers get loaded for albums if server has different ID for album and artwork #90

Closed
jcalado opened this issue Mar 20, 2023 · 9 comments
Labels
bug Something isn't working server:airsonic-advanced

Comments

@jcalado
Copy link

jcalado commented Mar 20, 2023

Wrong covers get loaded for albums

@dweymouth
Copy link
Owner

dweymouth commented Mar 20, 2023

@jcalado thanks for the report, but can you provide any more details? Are you using the latest release (alpha2)? Because I think this was fixed by #62 (setting a placeholder image when the server could not provide one, due to ratelimit, etc) which is in alpha-2 but not alpha-1

When you connect to a server for the first time, you might see a lot of the placeholder images because there aren't any cover images cached locally yet and your server might have a rate limit on the getCoverArt call.

@dweymouth dweymouth added unconfirmed An issue that has not (yet) been confirmed or reproed bug Something isn't working labels Mar 20, 2023
@jcalado
Copy link
Author

jcalado commented Mar 20, 2023

I'm building and running from the main branch, but the alpha-2 is also broken for me.
It appears as though my cache is not at all ok, several covers missing, multiple pngs with the same cover but different names as well .

Deleting the cache folder and restarting has no effect

@dweymouth
Copy link
Owner

Are you seeing the placeholder image (this], or are you seeing a cover for a different album showing up where it shouldn't?

@jcalado
Copy link
Author

jcalado commented Mar 20, 2023

I'm getting covers for other albums on my library. I'm using a docker image: airsonicadvanced/airsonic-advanced:latest

@jcalado
Copy link
Author

jcalado commented Mar 20, 2023

Scrolling down on the main albums grid downloaded more covers, but they're all messed up as well:
image

@dweymouth
Copy link
Owner

I've done most testing with Navidrome but in a bit I'll try spinning up airsonic-advanced against my own library and see if I can reproduce this. Thanks for the report - this definitely shouldn't be happening.

@jcalado
Copy link
Author

jcalado commented Mar 20, 2023

Thank you. Just FYI, airsonic-refix works OK with airsonic-advanced (eg: it shows the right covers)

@dweymouth dweymouth added server:airsonic-advanced and removed unconfirmed An issue that has not (yet) been confirmed or reproed labels Mar 20, 2023
@dweymouth dweymouth changed the title Wrong covers get loaded for albums Wrong covers get loaded for albums if server has different ID for album and artwork Mar 21, 2023
@dweymouth
Copy link
Owner

Fixed by 163d195. Thank you @jcalado! Now to continue testing with airsonic-advanced to see if there are any other bugs...

dweymouth added a commit that referenced this issue Mar 21, 2023
@jcalado
Copy link
Author

jcalado commented Mar 21, 2023

Thank you, that was fast :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server:airsonic-advanced
Projects
None yet
Development

No branches or pull requests

2 participants