depricated extension_whitelist change to extension_allowlist #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @janis-kalnins ! I'll remove 4.2 support to make the CI green. |
|
Hi there! This is a change that I'm very interested in using, but I noticed that this gem hasn't gotten a fresh release to Ruby Gems since Oct 2018. Are y'all planning on releasing this there at some point? |
|
Ah good point. I'll create a release. |
|
Thanks so much!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carrierwave 2.2.1 has move to extension_allowlist since it's depricated. So in order to this gem to work with the newest carrierwave gem we had to rename extension_whitelist to extension_allowlist.