Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all icons are generated (delete icon no needed?) #71

Closed
obsidianart opened this issue Feb 16, 2019 · 1 comment · Fixed by #83
Closed

Not all icons are generated (delete icon no needed?) #71

obsidianart opened this issue Feb 16, 2019 · 1 comment · Fixed by #83

Comments

@obsidianart
Copy link

I started my project from a boilerplate (from infinte red) and I used your app like I did in the past but it didn't work on some phone.
After a lot of research I think I found the problem: some icons are not generated.
It is likely that they are not needed, but if present they are used, probably the script should remove those:

  • /android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.png
  • /android/app/src/main/res/mipmap-xxhdpi/ic_launcher_round.png
  • /android/app/src/main/res/mipmap-xhdpi/ic_launcher_round.png
  • /android/app/src/main/res/mipmap-mdpi/ic_launcher_round.png
  • /imagzle/android/app/src/main/res/mipmap-hdpi/ic_launcher_round.png

Thanks for your amazing work.

dwmkerr added a commit that referenced this issue Apr 22, 2019
Fixes #71. Fixes #82. Ensures that we create the 'ldpi' (32x32) icons
for Android. Also ensures we create the round icons. If we do not create
these icons, then a project which _already_ has them will not show the
full set of icons properly.
@dwmkerr
Copy link
Owner

dwmkerr commented Apr 22, 2019

Thanks @obsidianart! This is now resolved in version 0.10.0, which generates the _round files as well, over-writing ones which will have been created by Android Studio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants