-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate to async/await #97
Conversation
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 96.84% 96.84%
=======================================
Files 17 17
Lines 222 222
=======================================
Hits 215 215
Misses 7 7
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 96.84% 99.07% +2.22%
==========================================
Files 17 16 -1
Lines 222 216 -6
==========================================
- Hits 215 214 -1
+ Misses 7 2 -5
Continue to review full report at Codecov.
|
@dwmkerr Could you take a first review at this? The node10 test failed as one of them went over 10 seconds strangely - if you kick it off again it should work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ace! I've left a few comments, some about your changes, some about potential improvements. If you agree with the potential improvements (which go beyond the scope of these changes) then comment and I'll raise separate tickets.
@dwmkerr Take another peek - removed the |
@mindmelting looking great. Can you squash and re-push? That way you will appear as the author in the commit history. If I squash, it'll create a single commit with me as the author and I'd like to keep you in the history, so that I can auto-generate 'contributor' files in the future. TY for the comments too @tobiasbueschel. The failing test seems intermittent, it might just need a longer timeout for the one which works on adaptive icons... |
92f747b
to
332434b
Compare
Squashed commits: [2f0b779] chore: Add in node eslint plugin and fix issues [b6b72ee] chore: Update to async / await [4bc6b40] chore: Refactor app-icon.js to async/await [9c000ab] chore: Remove node 6 from build [6b25ab7] chore: Update appveyor to use node 8 [06ee78c] chore: Updated documentation to reference node 8 [d77cc10] chore: Migrate to async/await BREAKING CHANGE: Support for Node 6 deprecated, now minimum Node 8
332434b
to
326d26f
Compare
@dwmkerr This should be squashed correctly now |
Released as Thanks for the help @mindmelting - this will make future changes much easier |
BREAKING CHANGE: Support for Node 6 deprecated, now minimum Node 8