Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show connection statistics #32

Merged
merged 4 commits into from
Nov 5, 2019
Merged

Conversation

dwmkerr
Copy link
Owner

@dwmkerr dwmkerr commented Nov 3, 2019

This PR adds the feature to show the number of connections and the
number of available connections.

It could be further improved by:

  • indicating active connections
  • colour coding the number of connections (e.g. green if less than 50%,
    yellow if < 80%, red otherwise.

TODO:

  • Separate the removal of the smallfiles flag which seems to be no longer used in mongo 4
  • Colour code the output of the number of connections
  • Unit tests for the new code
  • Update list of test files in the README

This PR adds the feature to show the number of connections and the
number of available connections.

It could be further improved by:

- indicating *active* connections
- colour coding the number of connections (e.g. green if less than 50%,
yellow if < 80%, red otherwise.
@dwmkerr dwmkerr mentioned this pull request Nov 3, 2019
@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #32 into master will increase coverage by 1.92%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   96.94%   98.87%   +1.92%     
==========================================
  Files           6        8       +2     
  Lines         131      178      +47     
==========================================
+ Hits          127      176      +49     
+ Misses          4        2       -2
Impacted Files Coverage Δ
src/lib/print-connections.spec.js 100% <100%> (ø)
src/lib/print-connections.js 100% <100%> (ø)
src/load-status.spec.js 100% <100%> (ø) ⬆️
src/load-status.js 94.87% <100%> (+5.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b02b432...13f3832. Read the comment docs.

@dwmkerr dwmkerr merged commit 769f7b2 into master Nov 5, 2019
@dwmkerr dwmkerr deleted the feat/show-connection-statistics branch November 5, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant