Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person session #13

Merged
merged 11 commits into from
Mar 5, 2020
Merged

Person session #13

merged 11 commits into from
Mar 5, 2020

Conversation

SimonLab
Copy link
Member

ref: #10

@SimonLab SimonLab self-assigned this Feb 27, 2020
@SimonLab SimonLab mentioned this pull request Feb 27, 2020
@SimonLab SimonLab temporarily deployed to app-mvp-elm February 28, 2020 07:03 Inactive
@SimonLab SimonLab temporarily deployed to app-mvp-elm February 28, 2020 07:53 Inactive
@SimonLab SimonLab temporarily deployed to app-mvp-elm February 28, 2020 07:57 Inactive
@SimonLab SimonLab requested a review from nelsonic March 5, 2020 13:59
@SimonLab SimonLab assigned nelsonic and unassigned SimonLab Mar 5, 2020
@SimonLab SimonLab temporarily deployed to app-mvp-elm March 5, 2020 14:14 Inactive
</noscript>
<script>
var flags = localStorage.getItem('store'); // get the person session from the local storage
var app = Elm.Main.init({ flags: flags });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the app override the whole <body> element?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. When you initialise a Elm.application Elm will manage the html body for you (and the title of the page)
From: https://guide.elm-lang.org/webapps/

You load whatever you need in the and you initialize your Elm program in the . The Elm program will take it from there and render everything.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab looks good. 🚀

@nelsonic nelsonic merged commit 61692c9 into master Mar 5, 2020
@nelsonic nelsonic deleted the person-session-#10 branch March 5, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants