Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressive web app - custom 'touch icon' on homescreen installation #100

Closed
1 task done
ghost opened this issue Aug 4, 2017 · 11 comments
Closed
1 task done

Progressive web app - custom 'touch icon' on homescreen installation #100

ghost opened this issue Aug 4, 2017 · 11 comments

Comments

@ghost
Copy link

ghost commented Aug 4, 2017

As a user that installs the application onto my homescreen (#37), I want the application to have the BestEvidence logo

  • Add the Best Evidence logo to the touch icon for mobile

@Cleop please can you add a time estimate to this?

@ghost ghost added the priority-3 label Aug 4, 2017
@ghost ghost added this to the Sprint 2 milestone Aug 4, 2017
@ghost ghost assigned Cleop Aug 4, 2017
@Cleop
Copy link
Member

Cleop commented Aug 7, 2017

Creates manifest.json, add custom 'apple-touch-icon' images for different devices which are linked in app.html

For Chrome:
https://developers.google.com/web/fundamentals/engage-and-retain/web-app-manifest/#customize_the_icons

Apple:
https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html

Then alters image to give white background. When used with no background the tile defaults to black which does not work for this logo.

@Cleop Cleop changed the title Progressive web app - logo on homescreen installation Progressive web app - custom 'touch icon' on homescreen installation Aug 7, 2017
@Cleop Cleop removed the in-progress label Aug 7, 2017
Cleop added a commit that referenced this issue Aug 7, 2017
Cleop added a commit that referenced this issue Aug 9, 2017
@ghost ghost added the please-test label Aug 16, 2017
@SimonLab SimonLab assigned ajburls and unassigned Cleop Aug 21, 2017
@ajburls
Copy link
Collaborator

ajburls commented Aug 21, 2017

@markwilliamfirth I get an icon for the app on the iPhone but not on the Android (Samsung S7) whether using Chrome or Dolphin to get an app on the home screen. I tried deleting the current icon for the app and then re-adding again just now and it did not renew with logo. Unfortunately since doing that I cannot login from the Android phone it says wrong username/password etc.

@ghost ghost added bug and removed please-test labels Aug 21, 2017
@ghost ghost assigned Cleop and unassigned ajburls Aug 23, 2017
@ghost
Copy link
Author

ghost commented Aug 25, 2017

There wasn't time to resolve this bug in sprint 2, so it will move to sprint 3

@ghost ghost modified the milestones: Sprint 3, Sprint 2 Aug 25, 2017
@ghost
Copy link
Author

ghost commented Aug 25, 2017

Moving this to priority 2 as Amanda mentioned in an email she would like this fixed as a priority

@ghost ghost added priority-2 and removed priority-3 labels Aug 25, 2017
@Cleop Cleop removed the in-progress label Sep 4, 2017
Cleop added a commit that referenced this issue Sep 4, 2017
samhstn pushed a commit that referenced this issue Sep 4, 2017
@SimonLab SimonLab assigned ajburls and unassigned Cleop Sep 4, 2017
@SimonLab
Copy link
Member

SimonLab commented Sep 4, 2017

@ajburls could you try on your android and iphone, I think @Cleop has updated this issue. Let us know if you still can't see the right icon when you add the application on your homescreen, thanks

@ajburls
Copy link
Collaborator

ajburls commented Sep 4, 2017

No icon on Android. Moreover, Android now not looking like an app as it did before (much nicer) but looking like a webpage with wasted space at top with address field etc. (No logo when save on to home page or in address.)

@ajburls
Copy link
Collaborator

ajburls commented Sep 4, 2017

tested in Chrome and Dolphin in case it made a difference. Would be better to revert to previous version if this can't be solved as preferable to have it look like an app.

@ghost
Copy link
Author

ghost commented Sep 5, 2017

@ajburls as a follow up to our call earlier, please retest this by following these steps:

  1. Remove the app from your homescreen
  2. Open chrome
  3. Click the three vertical dots at the top right to open the menu
  4. Select History
  5. Clear your history
  6. Close Chrome
  7. Reopen Chrome
  8. Go to Best Evidence app domain
  9. Click the three vertical dots at the top right to open the menu
  10. Click add to home screen
  11. Click Add

The app should appear with the logo, when it is opened there is no search bar / editable URL

Please let me know if this works or doesn't work

@ghost ghost added the please-test label Sep 5, 2017
@ajburls
Copy link
Collaborator

ajburls commented Sep 5, 2017

Looks great. I noticed a flash screen just before it opened that said "Best Evidence Practice" -it would be good if that could be changed to just "BestEvidence" (also if spaces can be removed from any other occurrence of best evidence e.g. About Best Evidence. Not critical but probably not very time consuming. Looks really nice now.

@Cleop
Copy link
Member

Cleop commented Sep 5, 2017

Phew! Glad we've got it working @ajburls 🎉

Happy to make the change for the copy, however, please can you open this as a new issue? Then you can close this issue.

@ghost
Copy link
Author

ghost commented Sep 5, 2017

Closed in favour of:

#207
#208

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants