Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meaningless appDir #16

Closed
ghost opened this issue Mar 16, 2016 · 3 comments
Closed

Meaningless appDir #16

ghost opened this issue Mar 16, 2016 · 3 comments
Labels
bug Suspected or confirmed bug (defect) in the code help wanted If you can help make progress with this issue, please comment!

Comments

@ghost
Copy link

ghost commented Mar 16, 2016

var appDir = path.dirname(require.main.filename);

Hi, man. This statement is meaningless, you should remove it.

@nelsonic
Copy link
Member

Hi @m31271n thanks for informing us that the line is unclear.
the line in question:

var appDir = path.dirname(require.main.filename);

resolves the path to the file which invoked the decache.
However, you are absolutely correct, the variable is defined and _never used_!! 😮
Let's remove it.
Do you have time to send us a Pull Request?

@nelsonic nelsonic added bug Suspected or confirmed bug (defect) in the code help wanted If you can help make progress with this issue, please comment! labels Mar 16, 2016
@ghost
Copy link
Author

ghost commented Mar 16, 2016

😄

@iteles
Copy link
Member

iteles commented Mar 16, 2016

Fixed with PR #17. Thanks @m31271n!

@iteles iteles closed this as completed Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Suspected or confirmed bug (defect) in the code help wanted If you can help make progress with this issue, please comment!
Projects
None yet
Development

No branches or pull requests

2 participants