Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phoenix Server #389

Closed
ghost opened this issue Sep 29, 2017 · 9 comments
Closed

Phoenix Server #389

ghost opened this issue Sep 29, 2017 · 9 comments
Assignees
Labels
dependency priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished question A question needs to be answered before progress can be made on this issue T2h Time Estimate 2 Hours
Milestone

Comments

@ghost
Copy link

ghost commented Sep 29, 2017

#237 (comment)

Required for #270

@ghost ghost added the priority-3 Third priority. Considered "Nice to Have". Not urgent. label Sep 29, 2017
@ghost ghost added this to the Backlog milestone Sep 29, 2017
@finnhodgkin finnhodgkin added the in-progress An issue or pull request that is being worked on by the assigned person label Oct 3, 2017
@dwyl dwyl deleted a comment from dwylbot bot Oct 3, 2017
@dwyl dwyl deleted a comment from dwylbot bot Oct 3, 2017
@finnhodgkin finnhodgkin added the T2h Time Estimate 2 Hours label Oct 3, 2017
@finnhodgkin
Copy link
Contributor

Started working on this because #378 is messing with dwyl's google-ability because https isn't working.

I've got most of the site running on a phoenix server, just need to sort out the 404 and the nested pages and then deploy to heroku. Happy to continue with this in the morning if you think it's higher priority than the elixir work.

@iteles
Copy link
Member

iteles commented Oct 3, 2017

@finnhodgkin 👍 👍 Let's get any other priorities of @markwilliamfirth's in first so there's a clear point in the history which adds the phoenix server.

@ghost
Copy link
Author

ghost commented Oct 3, 2017

@iteles this is a priority to solve #378 (p2) also allows us to do #270 (p2), which is also blocking other p2s, so phoenix server should probably move to a p2

@ghost ghost added priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished and removed priority-3 Third priority. Considered "Nice to Have". Not urgent. labels Oct 3, 2017
@ghost
Copy link
Author

ghost commented Oct 3, 2017

Would be great to get all the p2 issues done, others don't matter as much

@iteles
Copy link
Member

iteles commented Oct 3, 2017

I would strongly suggest that we don't want to do a move to templating #270 yet. We already have everything done without templating let's just get this up to resolve the original issue in the top description of this issue 👍

@ghost
Copy link
Author

ghost commented Oct 4, 2017

Templating would speed us up (whenever we need to update header and footer e.g. #197) and is going to be necessary eventually anyway and would remove chance of inconsistencies across pages, plus will be good for the blog

What's the reasoning behind not doing it?

@finnhodgkin
Copy link
Contributor

finnhodgkin commented Oct 4, 2017

@markwilliamfirth I think the main reasoning was that @iteles doesn't want to get locked in to a Phoenix implementation that isn't used in the future - Nelson has some plans for the blog and back-end that may not fit with a static site Phoenix server.

On the flip side I've lost at least a couple of hours in the last week purely on find/replace and manual copy-pasting of footers, headers, changes to team page bios, etc. It's also meant that it's easy for changes to be applied to all but one or two pages and then have the differences go unnoticed (for example when we arrived, a lot of pages had headers with no Google Tag Manager and a different set of favicons). However, the site is now in reasonably good shape so the sort of major changes that require mass find/replace are rare and will maybe take less time than building a phoenix version that may not be used as a permanent solution. 🤷‍♀️

@ghost
Copy link
Author

ghost commented Oct 4, 2017

Thanks @finnhodgkin

@nelsonic @iteles would be good to post the technical roadmap here so everyone is clear on where the project is going (I was under the impression a phoenix server would eventually be required anyway and wasn't aware a static phoenix server would lock us down and be a blocker for what's to come)

@ghost ghost added dependency question A question needs to be answered before progress can be made on this issue and removed in-progress An issue or pull request that is being worked on by the assigned person labels Oct 4, 2017
@ghost ghost assigned nelsonic and iteles and unassigned finnhodgkin Oct 4, 2017
@iteles iteles removed their assignment Nov 1, 2017
@nelsonic
Copy link
Member

Pointless issue without any requirements or acceptance criteria. closing.
GOTO: #270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished question A question needs to be answered before progress can be made on this issue T2h Time Estimate 2 Hours
Projects
None yet
Development

No branches or pull requests

3 participants