-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phoenix Server #389
Comments
Started working on this because #378 is messing with dwyl's google-ability because https isn't working. I've got most of the site running on a phoenix server, just need to sort out the 404 and the nested pages and then deploy to heroku. Happy to continue with this in the morning if you think it's higher priority than the elixir work. |
@finnhodgkin 👍 👍 Let's get any other priorities of @markwilliamfirth's in first so there's a clear point in the history which adds the phoenix server. |
Would be great to get all the p2 issues done, others don't matter as much |
I would strongly suggest that we don't want to do a move to templating #270 yet. We already have everything done without templating let's just get this up to resolve the original issue in the top description of this issue 👍 |
Templating would speed us up (whenever we need to update header and footer e.g. #197) and is going to be necessary eventually anyway and would remove chance of inconsistencies across pages, plus will be good for the blog What's the reasoning behind not doing it? |
@markwilliamfirth I think the main reasoning was that @iteles doesn't want to get locked in to a Phoenix implementation that isn't used in the future - Nelson has some plans for the blog and back-end that may not fit with a static site Phoenix server. On the flip side I've lost at least a couple of hours in the last week purely on find/replace and manual copy-pasting of footers, headers, changes to team page bios, etc. It's also meant that it's easy for changes to be applied to all but one or two pages and then have the differences go unnoticed (for example when we arrived, a lot of pages had headers with no Google Tag Manager and a different set of favicons). However, the site is now in reasonably good shape so the sort of major changes that require mass find/replace are rare and will maybe take less time than building a phoenix version that may not be used as a permanent solution. 🤷♀️ |
Thanks @finnhodgkin @nelsonic @iteles would be good to post the technical roadmap here so everyone is clear on where the project is going (I was under the impression a phoenix server would eventually be required anyway and wasn't aware a static phoenix server would lock us down and be a blocker for what's to come) |
Pointless issue without any requirements or acceptance criteria. closing. |
#237 (comment)
Required for #270
The text was updated successfully, but these errors were encountered: