-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds transparent, consistent favicons #386
Conversation
@ZooeyMiller, hoorah! 🎉 It's review time! 👀 I couldn't help but notice that there isn't an To save you time ⏳ I've added the Reviewer as an Assignee and I've added the Any questions, complaints, feedback, contributions? |
@ZooeyMiller, hoorah! 🎉 It's review time! 👀 I couldn't help but notice that there isn't an To save you time ⏳ I've added the Reviewer as an Assignee and I've added the Any questions, complaints, feedback, contributions? |
1 similar comment
@ZooeyMiller, hoorah! 🎉 It's review time! 👀 I couldn't help but notice that there isn't an To save you time ⏳ I've added the Reviewer as an Assignee and I've added the Any questions, complaints, feedback, contributions? |
@ZooeyMiller I pulled this down but for some reason it doesn't work for me |
2133d97
to
b619a8f
Compare
@markwilliamfirth should be working now! please check it out when you get a moment. |
@ZooeyMiller looks like there are conflicts? Not sure what's wrong - maybe it's me? 😬 |
@markwilliamfirth I don't have any conflicts locally, and I just pulled the branch. It wasn't working for @finnhodgkin before and is now, maybe try pulling again, and maybe doing a hard reload? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works! 😄
Adds consistent favicons, with a transparent background.
It'd be great if someone reviewing can pull this branch down and check it on their local machine (you'll have to use live-server so that the links work) because it all worked for me locally, but I don't trust favicons. 👀
Fix #329 #381