Chore: rename AWS_S3_BUCKET environment varialble names see: #86 (com…

…ment) ref: #80 / #69
dwyl · Jul 5, 2023 · 357c277 · 357c277
1 parent 02933e6
commit 357c277
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -44,8 +44,8 @@ jobs:
         AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
         AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
         AWS_REGION: eu-west-3
-        AWS_ORIGINAL_BUCKET: imgup-original
-        AWS_COMPRESSED_BUCKET: imgup-compressed
+        AWS_S3_BUCKET_ORIGINAL: imgup-original
+        AWS_S3_BUCKET_COMPRESSED: imgup-compressed
 
     - name: Upload coverage to Codecov
       uses: codecov/codecov-action@v1
diff --git a/README.md b/README.md
@@ -149,6 +149,8 @@ and add your credentials to it:
 export AWS_ACCESS_KEY_ID='YOUR_KEY'
 export AWS_SECRET_ACCESS_KEY='YOUR_KEY'
 export AWS_REGION='eu-west-3'
+export AWS_S3_BUCKET_ORIGINAL=imgup-original
+export AWS_S3_BUCKET_COMPRESSED=imgup-compressed
 ```
 
 In your terminal, run `source .env` to export the keys.

diff --git a/config/config.exs b/config/config.exs
@@ -54,8 +54,8 @@ config :ex_aws,
   access_key_id: System.get_env("AWS_ACCESS_KEY_ID"),
   secret_access_key: System.get_env("AWS_SECRET_ACCESS_KEY"),
   region: System.get_env("AWS_REGION"),
-  original_bucket: System.get_env("AWS_ORIGINAL_BUCKET"),
-  compressed_bucket: System.get_env("AWS_COMPRESSED_BUCKET"),
+  original_bucket: System.get_env("AWS_S3_BUCKET_ORIGINAL"),
+  compressed_bucket: System.get_env("AWS_S3_BUCKET_COMPRESSED"),
   request_config_override: %{}
 
 # Import environment specific config. This must remain at the bottom