Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Have bucket names imported env variables #80

Closed
LuchoTurtle opened this issue Jun 21, 2023 · 0 comments · Fixed by #83
Closed

chore: Have bucket names imported env variables #80

LuchoTurtle opened this issue Jun 21, 2023 · 0 comments · Fixed by #83
Assignees
@LuchoTurtle
Labels
chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished starter A beginner-friendly issue that is a good starting point for a new person T25m Time Estimate 25 Minutes tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@LuchoTurtle
Copy link
Member

As discussed in #70 (review), the buckets should be env variables because they are used across the application to upload files, retrieve the URLs of the latter, and show them to the person using the app/API.

Because the bucket names are implicitly used in these URLs and when creating the needed metadata to upload files from the LiveView, we ought to have them config'd and use them from there.
@LuchoTurtle LuchoTurtle added enhancement New feature or enhancement of existing functionality chore a tedious but necessary task often paying technical debt starter A beginner-friendly issue that is a good starting point for a new person labels Jun 21, 2023
@LuchoTurtle LuchoTurtle self-assigned this Jun 21, 2023
@LuchoTurtle LuchoTurtle changed the title chore: Use buckets as env variables chore: Have bucket names imported env variables Jun 21, 2023
@LuchoTurtle LuchoTurtle mentioned this issue Jun 21, 2023
Merged
4 tasks
@nelsonic nelsonic added priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written labels Jun 21, 2023
LuchoTurtle added a commit that referenced this issue Jun 26, 2023
@LuchoTurtle
fix: Buckets are now fetched from env variable. #80
4dbca12
@LuchoTurtle LuchoTurtle mentioned this issue Jun 26, 2023
Merged
nelsonic added a commit that referenced this issue Jul 5, 2023
@nelsonic
Chore: rename AWS_S3_BUCKET environment varialble names see: #86 (com…
357c277 
…ment) ref: #80 / #69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuchoTurtle LuchoTurtle

Labels
chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished starter A beginner-friendly issue that is a good starting point for a new person T25m Time Estimate 25 Minutes tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PR] Buckets are now fetched from env variable. dwyl/imgup
2 participants
@nelsonic @LuchoTurtle