Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: add "config :excid" to config.exs fixes #121 #122

Merged
merged 2 commits into from
Sep 19, 2023
Merged

PR: add "config :excid" to config.exs fixes #121 #122

merged 2 commits into from
Sep 19, 2023

Conversation

nelsonic
Copy link
Member

This should fix the cid mismatch noted in #121

@nelsonic nelsonic mentioned this pull request Sep 19, 2023
Closed
@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed priority-1 Highest priority issue. This is costing us money every minute that passes. technical A technical issue that requires understanding of the code, infrastructure or dependencies tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. labels Sep 19, 2023
@nelsonic
Copy link
Member Author

@LuchoTurtle this will fix the build. base58 is preferable to base32 because it uses fewer characters. 😉

@nelsonic nelsonic changed the title PR: add "config :excid" to config.exs #121 PR: add "config :excid" to config.exs fixes #121 Sep 19, 2023
LuchoTurtle
LuchoTurtle requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@LuchoTurtle LuchoTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add this to README so people know why this needs to be added?

@LuchoTurtle
Copy link
Member

I can add it, if you want to

@nelsonic
Copy link
Member Author

Thanks for updating the docs. Please merge when you can. Thanks. :shipit:

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #122 (d3633a4) into main (98a0417) will not change coverage.
Report is 14 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          130       130           
=========================================
  Hits           130       130

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LuchoTurtle LuchoTurtle merged commit a7d18ce into main Sep 19, 2023
3 checks passed
@LuchoTurtle LuchoTurtle deleted the fix-failing-build-cid-change-#121 branch September 19, 2023 09:27
@nelsonic nelsonic mentioned this pull request Sep 19, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuchoTurtle LuchoTurtle LuchoTurtle approved these changes

Assignees

@LuchoTurtle LuchoTurtle

Labels
awaiting-review An issue or pull request that needs to be reviewed priority-1 Highest priority issue. This is costing us money every minute that passes. T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. tech-debt A feature/requirement implemented in a sub-optimal way & must be re-written technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @LuchoTurtle