Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Build is failing #121

Closed
LuchoTurtle opened this issue Sep 19, 2023 · 4 comments
Closed

chore: Build is failing #121

LuchoTurtle opened this issue Sep 19, 2023 · 4 comments
Assignees
@LuchoTurtle
Labels
chore a tedious but necessary task often paying technical debt elixir Pull requests that update Elixir code

Comments

@LuchoTurtle
Copy link
Member

According to the last run(s), the build is failing.

It started by merging cc23a54. Might have something to do with the new version of https://github.com/dwyl/cid.
@LuchoTurtle LuchoTurtle added chore a tedious but necessary task often paying technical debt elixir Pull requests that update Elixir code labels Sep 19, 2023
@LuchoTurtle LuchoTurtle self-assigned this Sep 19, 2023
@LuchoTurtle
Copy link
Member Author

Running this locally, after running source .env, it works 🤔 .

The classic "it works on my computer" conundrum :/

nelsonic added a commit that referenced this issue Sep 19, 2023
@nelsonic
#121 add "config :excid" to config.exs
bd20a06
@nelsonic nelsonic mentioned this issue Sep 19, 2023
Merged
@nelsonic
Copy link
Member

nelsonic commented Sep 19, 2023 •
edited
Loading

Did you mix deps.get to get the latest version of cid?
image

The cid needs to be consistent across client and server.
i.e. the cid created in our Dart/Flutter app needs to match the one created in Elixir for the same string.
Please see: dwyl/cid#47

@nelsonic
Copy link
Member

PR: #122 passes. ✅

LuchoTurtle added a commit that referenced this issue Sep 19, 2023
@LuchoTurtle
chore: Adding section to README. #121
d3633a4
@LuchoTurtle
Copy link
Member Author

Closing, as #122 is merged and correctly fixes the issue 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuchoTurtle LuchoTurtle

Labels
chore a tedious but necessary task often paying technical debt elixir Pull requests that update Elixir code
Projects
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nelsonic @LuchoTurtle