Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaces single quote strings (charlists) with double quote strings #226

Merged
merged 1 commit into from
Sep 11, 2017

Conversation

finnhodgkin
Copy link
Collaborator

Although the code was working before, single quotes shouldn't be used for strings. 👍

#222

@codecov
Copy link

codecov bot commented Sep 8, 2017

Codecov Report

Merging #226 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #226   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines          76     76           
=====================================
  Hits           76     76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12deabd...e73e722. Read the comment docs.

Copy link
Member

@samhstn samhstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@samhstn samhstn merged commit af7c060 into master Sep 11, 2017
@samhstn samhstn deleted the bad-single-quote-strings branch September 11, 2017 15:39
@samhstn samhstn removed their assignment Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants