Adds 'updated' and 'created' timestamps for desktop site #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 7
Lines 76 76
=====================================
Hits 76 76Continue to review full report at Codecov.
|
samhstn
requested changes
Sep 11, 2017
web/templates/page/index.html.eex
Outdated
| <%= for issue <- @issues do %> | ||
| <%= component("issue_card", issue: issue, labels: get_label_data(issue) ) %> | ||
| <% end %> | ||
| </div> | ||
| </> |
There was a problem hiding this comment.
Atom packages going crazy?? My bad.
web/templates/page/index.html.eex
Outdated
| <th class="pv3 pl2">Repo</th> | ||
| <th><%= sort_link @conn, @rummage, [field: :repo_name, name: "Repo"] %></th> | ||
| <th><%= sort_link @conn, @rummage, [field: :gh_created_at, name: "Created"] %></th> | ||
| <th><%= sort_link @conn, @rummage, [field: :gh_updated_at, name: "Updated"] %></th> |
There was a problem hiding this comment.
Not sure if you need these [s, might be nicer without them
There was a problem hiding this comment.
Oh yeah course-keyword lists 🤦♂️. That's what we get for referencing the rummage docs.
samhstn
approved these changes
Sep 12, 2017
ZooeyMiller
approved these changes
Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mobile site shows created/updated but the desktop doesn't.
Also adds sort by links for repo, updated and created. Fixes #227
fixes #225