Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button to display all issues with no labels #236

Closed
wants to merge 7 commits into from

Conversation

finnhodgkin
Copy link
Collaborator

Adds:

  • an extra seed script that gets all issues with no labels
  • a new db table for issues with no labels
  • github hooks for issues with no labels
  • a route for label-less issues
  • tests

The code isn't very dry - the two index.html.eexs are practically identical and there's a lot of repeating stuff in hook_controller. Should we be pulling more stuff out to functions / using child templates?

fixes #229

@codecov
Copy link

codecov bot commented Sep 12, 2017

Codecov Report

Merging #236 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #236   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      8    +1     
  Lines          82    127   +45     
=====================================
+ Hits           82    127   +45
Impacted Files Coverage Δ
web/controllers/page_controller.ex 100% <100%> (ø) ⬆️
web/github/github_api.ex 100% <100%> (ø) ⬆️
web/controllers/unlabelled_controller.ex 100% <100%> (ø)
web/controllers/hook_controller.ex 100% <100%> (ø) ⬆️
test/support/test_helpers.ex 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29df0e3...b968f13. Read the comment docs.

@finnhodgkin finnhodgkin changed the title Add an button to display all issues with no labels Add a button to display all issues with no labels Sep 12, 2017
Copy link
Member

@samhstn samhstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to add another table?

Why would the issues not suffice, we have a labels column?

@finnhodgkin finnhodgkin deleted the no-label-issues branch September 13, 2017 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have an option to show issues with no labels
5 participants