adds links to assignee's github profiles #246
Conversation
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 7
Lines 82 82
=====================================
Hits 82 82Continue to review full report at Codecov.
|
| @@ -53,7 +53,9 @@ | |||
| </td> | |||
| <td class="tc"> | |||
| <%= for assignee <- generate_avatar(issue) do %> | |||
| <img src="https://www.github.com/<%= assignee %>.png" alt="<%= assignee %>'s github avatar'" class="w1plus br2"> | |||
| <a href="https://www.github.com/<%= assignee %>" title="<%= assignee %>"> | |||
| <img src="https://www.github.com/<%= assignee %>.png" alt="<%= assignee %>'s github avatar'" class="w1plus br2"> | |||
There was a problem hiding this comment.
This avatar png link is much nicer than what I've been using 👍
We should be referencing images like this in the future.
(From here, https://github.com/shouston3.png would have been so much nicer than https://avatars3.githubusercontent.com/u/15983736?v=4&u=8b6cfb76f2bf2c65dc0b215e179abe1d4cf9c42a&s=400)
There was a problem hiding this comment.
Yeah I was so surprised when I discovered it! I didn't even know redirect urls could be used as img src.
Turns the assignee images into links to the assignee's github profile, and makes it to that when the cursor hovers an assignee's image, the assignee's github username shows.
fix #245