This repository has been archived by the owner on Jun 2, 2023. It is now read-only.
Feature/header log #598
Merged
Feature/header log #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aly76
suggested changes
Nov 21, 2021
aly76
reviewed
Nov 23, 2021
|
Tested all commands, PMD and all of Org Commands do not display the Header |
aly76
reviewed
Nov 24, 2021
| @@ -16,7 +17,7 @@ core.Messages.importMessagesDirectory(__dirname); | |||
| // or any library that is using the messages framework can also be loaded this way. | |||
| const messages = core.Messages.loadMessages("sfpowerkit", "source_pmd"); | |||
|
|
|||
| export default class Pmd extends SfdxCommand { | |||
| export default class Pmd extends SFPowerkitCommand { | |||
There was a problem hiding this comment.
The Pmd class needs an explicitly defined --loglevel flag where the default level is set to INFO, otherwise the level is WARN which stops the header in SfpowerkitCommand from printing.
aly76
reviewed
Nov 24, 2021
aly76
reviewed
Nov 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added and tested Display headers for all sfpowerkit command with version and release