Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Refactor package installation implementation to use packaging lib #1121

Closed
azlam-abdulsalam opened this issue Sep 13, 2022 · 2 comments · Fixed by #1161
Closed

Refactor package installation implementation to use packaging lib #1121

azlam-abdulsalam opened this issue Sep 13, 2022 · 2 comments · Fixed by #1161
Assignees
@davidzheng1310
Labels
refactor
Milestone
Release - Novembe...

Comments

@azlam-abdulsalam
Copy link
Contributor

Refactor the current implementation of installing packages that wrap around sfdx cli to use the underlying library directly. The new library is available here https://github.com/forcedotcom/packaging

This will allow us to handle parallel packaging and errors much more cleanly and remove dependency on the CLI invocation
@github-actions github-actions bot added the analysis To be decided on how to solution/fix label Sep 13, 2022
@azlam-abdulsalam azlam-abdulsalam removed the analysis To be decided on how to solution/fix label Sep 13, 2022
@vuha-acn
Copy link
Contributor

@azlam-abdulsalam The CLI team says "⚠️ This module is under heavy development, please do not use in production." Are we going to schedule the refactoring release of the code when it's GA or just risk it and use it as it is?

@azlam-abdulsalam
Copy link
Contributor Author

@vuha-acn When the current cli package:beta goes GA, we will switch to the lib

azlam-abdulsalam pushed a commit that referenced this issue Nov 30, 2022
refactor(packaging): use @salesforce/packaging lib instead of sfdx-cli
71e08e1 
Use @salesforce/packaging lib which is stable and used behind the scenes in sfdx-cli. This would
aling to the earlier DR where sfpowerscripts will not wrap around cli anymore and use the native
libraries instead for more control

fix #1121
@azlam-abdulsalam azlam-abdulsalam mentioned this issue Nov 30, 2022
Merged
5 tasks
@azlam-abdulsalam azlam-abdulsalam linked a pull request Nov 30, 2022 that will close this issue
refactor(packaging): use @salesforce/packaging lib instead of sfdx-cli #1161
Merged
5 tasks
azlam-abdulsalam added a commit that referenced this issue Dec 1, 2022
@azlam-abdulsalam
refactor(packaging): use @salesforce/packaging lib instead of sfdx-cli (
7e25ed2 
#1161)

* refactor(packaging): use @salesforce/packaging lib instead of sfdx-cli

Use @salesforce/packaging lib which is stable and used behind the scenes in sfdx-cli. This would
aling to the earlier DR where sfpowerscripts will not wrap around cli anymore and use the native
libraries instead for more control

fix #1121

* chore(install2): remove test class

* Update packages/core/src/package/packageInstallers/InstallUnlockedPackage.ts
azlam-abdulsalam added a commit that referenced this issue Dec 1, 2022
@azlam-abdulsalam
refactor(packaging): use @salesforce/packaging lib instead of sfdx-cli (
68cb1d0 
#1161)

* refactor(packaging): use @salesforce/packaging lib instead of sfdx-cli

Use @salesforce/packaging lib which is stable and used behind the scenes in sfdx-cli. This would
aling to the earlier DR where sfpowerscripts will not wrap around cli anymore and use the native
libraries instead for more control

fix #1121

* chore(install2): remove test class

* Update packages/core/src/package/packageInstallers/InstallUnlockedPackage.ts
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidzheng1310 davidzheng1310

Labels
refactor
Projects
None yet
Milestone
Release - November 2022
Development

Successfully merging a pull request may close this issue.

refactor(packaging): use @salesforce/packaging lib instead of sfdx-cli dxatscale/sfpowerscripts
4 participants
@azlam-abdulsalam @davidzheng1310 @vuha-acn @zhebinliu