Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

fix(links): add $schema properties #1203

Merged
merged 2 commits into from
Apr 19, 2023
Merged

fix(links): add $schema properties #1203

merged 2 commits into from
Apr 19, 2023

Conversation

alanjaouen
Copy link
Contributor

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d8e6f57) 62.11% compared to head (5f00c80) 62.11%.

❗ Current head 5f00c80 differs from pull request most recent head e2878c6. Consider uploading reports for the commit e2878c6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1203   +/-   ##
=======================================
  Coverage   62.11%   62.11%           
=======================================
  Files          61       61           
  Lines        2085     2085           
  Branches      439      439           
=======================================
  Hits         1295     1295           
  Misses        790      790           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okie

@azlam-abdulsalam azlam-abdulsalam merged commit 6349a83 into dxatscale:main Apr 19, 2023
@reviewpad reviewpad bot added the small Pull request is small label Apr 19, 2023
@reviewpad
Copy link

reviewpad bot commented Apr 19, 2023

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'Merge branch 'main' into patch-2' (e2878c6)

⚠️ Warnings

  • Please link an issue to the pull request
  • Please rebase your pull request on the latest changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants