This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
feat(install): introduce a unified package installation command #1420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a unified package install command, that allows to use a single command to install
any spowerscripts artifact. This reduces complexity to while scripting pipelines to understand
the type of package and install it in one go. The change also deprecates other commands
BREAKING CHANGE: deprecates existing individual package installation commands
Summary generated by Reviewpad on 10 Oct 23 04:55 UTC
This pull request includes the following changes:
install_package.json
has been added to thepackages/sfpowerscripts-cli/messages
directory. The file contains JSON data describing command and flag descriptions for installing a sfpowerscripts artifact to an org.install_unlocked_package.json
file. It is now marked as deprecated and includes information about retrieving the version ID of the package from the build artifact.install.ts
file has been modified to importSFPLogger
andLoggerLevel
from the@dxatscale/sfp-logger
library. It also includes a deprecation flag and a warning log message. The deprecated status of the command is set to true and a new log message informs users to use thesfp package:install
command instead.install.ts
has been added, which contains code for installing a package using SFPowerScript commands. It includes imports and a class calledInstall
that extends theInstallPackageCommand
class. The file also defines flags for the command and implements theinstall
method for package installation.install_data_package.json
file has been updated to indicate that the command is deprecated. The corresponding comment has been modified accordingly.InstallPackageCommand.ts
file has been modified to remove theskiponmissingartifact
flag that was previously defined.Please review these changes and ensure that they meet the requirements.
Checklist
All items have to be completed before a PR is merged