Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

fix(apex-test): additional parallel run error #1436

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

jdrbc
Copy link
Contributor

@jdrbc jdrbc commented Nov 3, 2023

retry on 'Too many concurrent Apex compilations during resource mitigation' & 'LIMIT_EXCEEDED'

related issue: #1437

Summary generated by Reviewpad on 03 Nov 23 23:28 UTC

This pull request fixes an error that occurs during parallel runs of Apex tests. The patch adds retries for errors related to 'Too many concurrent Apex compilations during resource mitigation' and 'LIMIT_EXCEEDED'.

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

retry on 'Too many concurrent Apex compilations
during resource mitigation' & 'LIMIT_EXCEEDED'
Copy link

reviewpad bot commented Nov 3, 2023

Thank you @jdrbc for this first contribution!

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Nov 3, 2023
Copy link

reviewpad bot commented Nov 3, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db5b22a) 46.86% compared to head (a776826) 46.86%.

❗ Current head a776826 differs from pull request most recent head 7c5ee58. Consider uploading reports for the commit 7c5ee58 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1436   +/-   ##
=======================================
  Coverage   46.86%   46.86%           
=======================================
  Files          70       70           
  Lines        2665     2665           
  Branches      302      302           
=======================================
  Hits         1249     1249           
  Misses       1414     1414           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdrbc
Copy link
Contributor Author

jdrbc commented Nov 7, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

#1437

@azlam-abdulsalam
Copy link
Contributor

Thanks @jdrbc ,will merge this in.

@azlam-abdulsalam azlam-abdulsalam merged commit 0403a24 into dxatscale:main Nov 7, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants