Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Horizontal Slider Fix #1795

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Tab Horizontal Slider Fix #1795

merged 6 commits into from
Feb 7, 2024

Conversation

Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Feb 1, 2024

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
There was a problem firing the load event and the scroll arrows would only display inside Tabs when resizing the window.

It is now solved thanks to changing the way that the first load is handled.

Closes #1681

@Mil4n0r Mil4n0r marked this pull request as ready for review February 1, 2024 09:42
@jsuarezgonz jsuarezgonz self-assigned this Feb 6, 2024
@jsuarezgonz jsuarezgonz merged commit 3ac400c into master Feb 7, 2024
2 checks passed
@jsuarezgonz jsuarezgonz deleted the Mil4n0r/tabs-fix branch February 7, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs Component should show Horizontal scroller if tabs go out of view of the container
2 participants