Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table cell text height overriding #118

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

DeepankarGupta13
Copy link
Contributor

Added cell text overriding flag and cell text height group code for ACAD_TABLE

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.04 ⚠️

Comparison is base (13885fa) 91.20% compared to head (7d366f6) 91.17%.

❗ Current head 7d366f6 differs from pull request most recent head bae2a03. Consider uploading reports for the commit bae2a03 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   91.20%   91.17%   -0.04%     
==========================================
  Files          92       92              
  Lines        8108     8113       +5     
  Branches      483      483              
==========================================
+ Hits         7395     7397       +2     
- Misses        713      716       +3     
Impacted Files Coverage Δ
src/Sections/EntitiesSection/Entities/Table.ts 49.56% <40.00%> (-0.44%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tarikjabiri tarikjabiri changed the title FIX: Table cell text height overriding fix: table cell text height overriding Jun 29, 2023
@tarikjabiri tarikjabiri merged commit 3b10f12 into dxfjs:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants