feat(cli-dxns): Default deploy path is out/<encoded-dxn> #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richburdon
approved these changes
May 11, 2022
|
|
||
| const publishFolder = path.join(process.cwd(), distPath || module.build!.outdir!); | ||
| const outPath = path ?? module.build?.outdir ?? `out/${encodeName(module.name!)}`; |
There was a problem hiding this comment.
hey @wittjosiah it's kinda not intuitive, but module.build.outdir will always be defined because of https://github.com/dxos/cli/blob/main/packages/cli-dxns/src/utils/config.ts#L66
There was a problem hiding this comment.
Oh interesting. Is this value used anywhere else that you're aware of? Would removing that default value when the config is loaded and determining it dynamically here break things elsewhere?
There was a problem hiding this comment.
I think it's used only here;
I guess the idea was to have all "default" consts & logic inside config.ts (to have it in one place), and on the level of command handler allow only override with cli args
egorgripasov
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.