feat: Add book-specific config #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richburdon
requested changes
Mar 9, 2022
| @@ -88,7 +88,7 @@ export const bookCommand: CommandModule<{}, BookCommandArgv> = { | |||
| const projectRoot = process.cwd(); | |||
| const packageRoot = getPackageRoot(); | |||
| const staticDir = join(packageRoot, 'src/book/ui/public'); | |||
| const outdir = config?.outdir || './dist'; | |||
| const outdir = config?.book?.outdir || './out-book'; | |||
There was a problem hiding this comment.
I notied the conflict here, but don't like compound directory names. Can this be made to work with out/book?
There was a problem hiding this comment.
Haha, I had a feeling you were going to suggest this! I think this can definitely work but comes with a different tradeoff: either that will mean that the book output is included in the bundle (likely harmless but wasteful and messy) or we need to path the default output of the app as well. If we path the default output of the app then it will no longer match the default path of the dx ns deploy command and it will always need to be specified.
Given all this I think my suggestion would be:
- default esbuild-server outdir is
out- this would work the default
dx ns deploycommand
- this would work the default
- default esbuild-server book outdir is
out/book- we'll need to specify the path for the deploy command for this no matter what it is since it can't match the default so that's fine
- if you're building both, then you would need to change the outdir config to something like
out/appand specify that for the deploy path as well - this keeps the default usecase simple but allows for flexibilty for our usecase where we're publishing the storybooks as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.