Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8 support #38

Merged
merged 6 commits into from
May 9, 2023
Merged

Add PHP 8 support #38

merged 6 commits into from
May 9, 2023

Conversation

RobjS
Copy link
Contributor

@RobjS RobjS commented May 9, 2023

This PR:

  • Adds support for PHP 8.1 and 8.2 (not 8.0, which is no longer in active support)
  • Removes support for PHP versions below 7.4
  • Implements the standard dxw PHP CS Fixer config

RobjS added 3 commits May 9, 2023 09:39
We don't run anything below 7.4 on any infrastructures anymore.
8.0 isn't in active support, so we're only really interested in 8.1 and
up.

I'm aware this is also true of 7.4, strictly speaking, but we're still
running that everywhere at the moment, so need to support it.
@RobjS RobjS changed the title Chore/test in php 8 Add PHP 8 support May 9, 2023
RobjS added 3 commits May 9, 2023 10:03
No we're no longer supporting PHP versions below PHP 7.4, we can upgrade
PHPUnit. This should, in turn, allow us to update PHP CS Fixer to a
version compatible with PHP 8.2.
Copy link

@jkeasley jkeasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobjS RobjS merged commit 273c85f into main May 9, 2023
@RobjS RobjS deleted the chore/test-in-php-8 branch May 9, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants