Make load balancing configurable

[Victor-M-Giraldo]

• Closes make the load balancing algorithm configurable #1294

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.3344%. Comparing base (44aa6a5) to head (fcfa1e0).
Report is 4 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master      #1573        +/-   ##
================================================
- Coverage   61.3468%   61.3344%   -0.0124%     
================================================
  Files           170        170                
  Lines         24844      24849         +5     
  Branches       1461       1462         +1     
================================================
  Hits          15241      15241                
- Misses         9547       9552         +5     
  Partials         56         56                

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dyc3]

Looks good so far.

[Victor-M-Giraldo]

impl Default for BalancerContext {
    fn default() -> Self {
        BalancerContext {
            clients: HashMap::default(),
            monoliths: HashMap::default(),
            rooms_to_monoliths: HashMap::default(),
            monoliths_by_region: HashMap::default(),
            monolith_selection: Box::new(BalancerConfig::get().selection_strategy),
        }
    }
}

Shouldn't something like this work? It's asking me to implement the trait for the enum though I think which makes no sense to me. Am I going in the wrong direction here though?

[dyc3]

It only works if you implement the trait for the enum. The enum does not automatically implement traits that the variants implement. The enum is a completely new type.

[Victor-M-Giraldo]

I'm trying to figure out why these tests are failing. I'm running cargo test with RUST_BACKTRACE = 1. Do you think you could look?

[Victor-M-Giraldo]

/rerun

[dyc3]

Looking good

[Victor-M-Giraldo]

Why is the config failing to be initialized. I thought this logic is okay. If Some(selection_strategy) set it in the balancer context, else use the default, where the default for selection_strategy would be Min_rooms

Nevermind, saw the above review.

[cypress]

Passing run #1589 ↗︎

0

79

1

0

0

Details:

Make load balancing configurable (#1573)
Project: OpenTogetherTube	Commit: 61acd32d69
Status: Passed	Duration: 04:38 💡
Started: Apr 6, 2024 7:40 PM	Ended: Apr 6, 2024 7:44 PM

Review all test suite changes for PR #1573 ↗︎