vis: TopologyView: surround regions with bounding boxes #1615

dyc3 · 2024-04-04T21:12:01Z

No description provided.

coderabbitai · 2024-04-04T21:12:05Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

dyc3 · 2024-04-04T21:12:17Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dyc3 and the rest of your teammates on Graphite

codecov · 2024-04-04T21:16:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.3335%. Comparing base (30b1b21) to head (fd34cce).
Report is 1 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master      #1615        +/-   ##
================================================
+ Coverage   61.3211%   61.3335%   +0.0124%     
================================================
  Files           170        170                
  Lines         24843      24851         +8     
  Branches       1461       1461                
================================================
+ Hits          15234      15242         +8     
  Misses         9553       9553                
  Partials         56         56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cypress · 2024-04-04T21:18:17Z

Passing run #1546 ↗︎

0	79	1	0	0

Details:

Merge `fd34cce` into `30b1b21`...
Project: OpenTogetherTube	Commit: `d01bbd6d56 ℹ️`
Status: Passed	Duration: 04:59 💡
Started: Apr 4, 2024 10:39 PM	Ended: Apr 4, 2024 10:44 PM

Review all test suite changes for PR #1615 ↗︎

dyc3 · 2024-04-04T21:36:32Z

Merge activity

Apr 4, 5:36 PM EDT: @dyc3 started a stack merge that includes this pull request via Graphite.
Apr 4, 5:42 PM EDT: Graphite couldn't merge this pull request because a downstack PR vis: refactor zoom code into a reusable useD3Zoom hook #1612 failed to merge.
Apr 4, 6:27 PM EDT: @dyc3 started a stack merge that includes this pull request via Graphite.
Apr 4, 6:27 PM EDT: Graphite couldn't merge this pull request because a downstack PR vis: TopologyView: accept node radius props #1613 failed to merge.
Apr 4, 6:31 PM EDT: @dyc3 started a stack merge that includes this pull request via Graphite.
Apr 4, 6:31 PM EDT: Graphite couldn't merge this pull request because a downstack PR vis: TopologyView: accept node radius props #1613 failed to merge.
Apr 4, 6:32 PM EDT: @dyc3 started a stack merge that includes this pull request via Graphite.
Apr 4, 6:38 PM EDT: Graphite rebased this pull request as part of a merge.
Apr 4, 6:42 PM EDT: @dyc3 merged this pull request with Graphite.

cypress · 2024-04-04T22:48:57Z

Passing run #1547 ↗︎

0	79	1	0	0

Details:

vis: TopologyView: surround regions with bounding boxes (#1615)
Project: OpenTogetherTube	Commit: `396eb1de72`
Status: Passed	Duration: 05:13 💡
Started: Apr 4, 2024 10:43 PM	Ended: Apr 4, 2024 10:48 PM

Review all test suite changes for PR #1615 ↗︎

dyc3 force-pushed the 04-04-vis_topologyview_surround_regions_with_bounding_boxes branch from e4477d8 to 0389867 Compare April 4, 2024 21:17

dyc3 marked this pull request as ready for review April 4, 2024 21:17

dyc3 force-pushed the 04-04-vis_topologyview_group_subtrees_by_region branch from fff5d8c to 9f5a422 Compare April 4, 2024 21:25

dyc3 force-pushed the 04-04-vis_topologyview_surround_regions_with_bounding_boxes branch from 0389867 to 45d0067 Compare April 4, 2024 21:25

dyc3 force-pushed the 04-04-vis_topologyview_group_subtrees_by_region branch from 9f5a422 to 1883a33 Compare April 4, 2024 22:02

dyc3 force-pushed the 04-04-vis_topologyview_surround_regions_with_bounding_boxes branch from 45d0067 to aa46a98 Compare April 4, 2024 22:02

dyc3 force-pushed the 04-04-vis_topologyview_group_subtrees_by_region branch from 1883a33 to 84e2383 Compare April 4, 2024 22:33

Base automatically changed from 04-04-vis_topologyview_group_subtrees_by_region to master April 4, 2024 22:37

vis: TopologyView: surround regions with bounding boxes

fd34cce

dyc3 force-pushed the 04-04-vis_topologyview_surround_regions_with_bounding_boxes branch from aa46a98 to fd34cce Compare April 4, 2024 22:37

dyc3 merged commit 396eb1d into master Apr 4, 2024
23 checks passed

dyc3 deleted the 04-04-vis_topologyview_surround_regions_with_bounding_boxes branch April 4, 2024 22:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vis: TopologyView: surround regions with bounding boxes #1615

vis: TopologyView: surround regions with bounding boxes #1615

dyc3 commented Apr 4, 2024

coderabbitai bot commented Apr 4, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

dyc3 commented Apr 4, 2024 •

edited

Loading

codecov bot commented Apr 4, 2024 •

edited

Loading

cypress bot commented Apr 4, 2024 •

edited

Loading

dyc3 commented Apr 4, 2024 •

edited

Loading

cypress bot commented Apr 4, 2024

vis: TopologyView: surround regions with bounding boxes #1615

vis: TopologyView: surround regions with bounding boxes #1615

Conversation

dyc3 commented Apr 4, 2024

coderabbitai bot commented Apr 4, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

dyc3 commented Apr 4, 2024 • edited Loading

codecov bot commented Apr 4, 2024 • edited Loading

Codecov Report

cypress bot commented Apr 4, 2024 • edited Loading

Passing run #1546 ↗︎

Review all test suite changes for PR #1615 ↗︎

dyc3 commented Apr 4, 2024 • edited Loading

Merge activity

cypress bot commented Apr 4, 2024

Passing run #1547 ↗︎

Review all test suite changes for PR #1615 ↗︎

CodeRabbit Configration File (`.coderabbit.yaml`)

dyc3 commented Apr 4, 2024 •

edited

Loading

codecov bot commented Apr 4, 2024 •

edited

Loading

cypress bot commented Apr 4, 2024 •

edited

Loading

dyc3 commented Apr 4, 2024 •

edited

Loading