Do not emit stat if we are skipping block (#1202)

dydxprotocol · Mar 19, 2024 · a550d20 · a550d20
1 parent be4ba54
commit a550d20
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/indexer/services/ender/__tests__/lib/on-message.test.ts b/indexer/services/ender/__tests__/lib/on-message.test.ts
@@ -761,7 +761,7 @@ describe('on-message', () => {
 
     expect(stats.increment).toHaveBeenCalledWith(`${config.SERVICE_NAME}.block_already_parsed`, 1);
     expect(stats.increment).toHaveBeenCalledWith('ender.received_kafka_message', 1);
-    expect(stats.timing).toHaveBeenCalledWith(
+    expect(stats.timing).not.toHaveBeenCalledWith(
       'ender.message_time_in_queue', expect.any(Number), 1, { topic: KafkaTopics.TO_ENDER });
   });
 

diff --git a/indexer/services/ender/src/lib/on-message.ts b/indexer/services/ender/src/lib/on-message.ts
@@ -49,7 +49,6 @@ export async function onMessage(message: KafkaMessage): Promise<void> {
   const start: number = Date.now();
   const indexerTendermintBlock: IndexerTendermintBlock | undefined = getIndexerTendermintBlock(
     message,
-    start,
   );
   if (indexerTendermintBlock === undefined) {
     return;
@@ -66,6 +65,15 @@ export async function onMessage(message: KafkaMessage): Promise<void> {
     return;
   }
 
+  stats.timing(
+    `${config.SERVICE_NAME}.message_time_in_queue`,
+    start - Number(message.timestamp),
+    STATS_NO_SAMPLING,
+    {
+      topic: KafkaTopics.TO_ENDER,
+    },
+  );
+
   let success: boolean = false;
   const txId: number = await Transaction.start();
   await Transaction.setIsolationLevel(txId, IsolationLevel.READ_UNCOMMITTED);
@@ -141,7 +149,6 @@ export async function onMessage(message: KafkaMessage): Promise<void> {
  */
 function getIndexerTendermintBlock(
   message: KafkaMessage,
-  start: number,
 ): IndexerTendermintBlock | undefined {
   if (!message || !message.value || !message.timestamp) {
     stats.increment(`${config.SERVICE_NAME}.empty_kafka_message`, 1);
@@ -151,15 +158,6 @@ function getIndexerTendermintBlock(
     });
     return undefined;
   }
-
-  stats.timing(
-    `${config.SERVICE_NAME}.message_time_in_queue`,
-    start - Number(message.timestamp),
-    STATS_NO_SAMPLING,
-    {
-      topic: KafkaTopics.TO_ENDER,
-    },
-  );
   try {
     const messageValueBinary: Uint8Array = new Uint8Array(message.value);
     logger.info({