Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cosmos fork to use libsecp256k1 from go-ethereum #1210

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Upgrade cosmos fork to use libsecp256k1 from go-ethereum #1210

merged 1 commit into from
Mar 20, 2024

Conversation

roy-dydx
Copy link
Contributor

Changelist

Previously we had to revert libsecp256k1 because of duplicate symbol issue. Using it from go-ethereum directly solves this issue.

Test Plan

Existing tests

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 20, 2024 •
edited
Loading

Walkthrough

The update involves a simplification in the build process for a protocol, specifically removing a conditional check that previously enabled libsecp256k1_sdk based on whether COSMOS_BUILD_OPTIONS included secp. This change streamlines the setup by no longer making the inclusion of libsecp256k1_sdk contingent on the presence of secp in the build options.

Changes

File(s) Change Summary
protocol/Makefile Removed the condition for enabling libsecp256k1_sdk based on COSMOS_BUILD_OPTIONS containing secp.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot]
coderabbitai bot reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 12e9e28 and de0042a.
Files ignored due to path filters (2)
  • protocol/go.mod is excluded by: !**/*.mod
  • protocol/go.sum is excluded by: !**/*.sum
Files selected for processing (1)
  • protocol/Makefile (1 hunks)

coderabbitai[bot]
coderabbitai bot reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 852930e and 3cafec9.
Files ignored due to path filters (2)
  • protocol/go.mod is excluded by: !**/*.mod
  • protocol/go.sum is excluded by: !**/*.sum
Files selected for processing (1)
  • protocol/Makefile (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • protocol/Makefile

coderabbitai[bot]
coderabbitai bot reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 852930e and c3b4847.
Files ignored due to path filters (2)
  • protocol/go.mod is excluded by: !**/*.mod
  • protocol/go.sum is excluded by: !**/*.sum
Files selected for processing (1)
  • protocol/Makefile (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • protocol/Makefile

@roy-dydx roy-dydx merged commit 42cbee6 into main Mar 20, 2024
16 of 17 checks passed
@roy-dydx roy-dydx deleted the roy/c branch March 20, 2024 20:23
roy-dydx added a commit that referenced this pull request Mar 22, 2024
@roy-dydx
Upgrade cosmos fork to use libsecp256k1 from go-ethereum (#1210)
93cf754
roy-dydx added a commit that referenced this pull request Mar 22, 2024
@roy-dydx
Upgrade cosmos fork to use libsecp256k1 from go-ethereum (#1210)
4c09cf0
roy-dydx added a commit that referenced this pull request May 14, 2024
@roy-dydx
Upgrade cosmos fork to use libsecp256k1 from go-ethereum (#1210)
4634713
@roy-dydx
Copy link
Contributor Author

@Mergifyio backport release/protocol/v4.1.x

@mergify Mergify
Copy link
Contributor

mergify bot commented May 14, 2024 •
edited
Loading

backport release/protocol/v4.1.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 14, 2024
@roy-dydx @mergify
Upgrade cosmos fork to use libsecp256k1 from go-ethereum (#1210)
294e7fd 
(cherry picked from commit 42cbee6)

# Conflicts:
#	protocol/go.mod
#	protocol/go.sum
@mergify mergify bot mentioned this pull request May 14, 2024
Merged
6 tasks
roy-dydx added a commit that referenced this pull request May 14, 2024
@mergify @roy-dydx
Upgrade cosmos fork to use libsecp256k1 from go-ethereum (backport #1210
0f19dd1 
) (#1517)

* Upgrade cosmos fork to use libsecp256k1 from go-ethereum (#1210)

(cherry picked from commit 42cbee6)

# Conflicts:
#	protocol/go.mod
#	protocol/go.sum

* resolve conflict

---------

Co-authored-by: roy-dydx <133032749+roy-dydx@users.noreply.github.com>
Co-authored-by: Roy Li <roy@dydx.exchange>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@BrendanChou BrendanChou BrendanChou approved these changes

Assignees
No one assigned
Labels
protocol
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roy-dydx @BrendanChou