[CT-755] implement logic for FIRST_STRIKE_CLOSE_ONLY mode #1372
Conversation
WalkthroughThe recent update introduces a new compliance status, Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
dydxwill
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Actionable comments outside the diff hunks (38)
indexer/services/comlink/public/api-documentation.md (38)
Line range hint
14-14: Consider correcting the possible spelling mistake found near line 14.- v4</a> # Authentication # Default ## GetAddress <a id="opIdGetAddress"></a> > Code sa... + v4</a> # Authentication # Default ## GetAddress <a id="opIdGetAddress"></a> > Code samples...
Line range hint
137-137: Consider correcting the possible spelling mistake found near line 137.- etf.org/html/rfc7231#section-6.3.1)|Ok|[AddressResponse](#schemaaddressresponse)| <aside class... + ietf.org/html/rfc7231#section-6.3.1)|Ok|[AddressResponse](#schemaaddressresponse)| <aside class...
Line range hint
143-143: Consider correcting the possible spelling mistake found near line 143.- not require authentication </aside> ## GetSubaccount <a id="opIdGetSubaccount"></a> > Code... + not require authentication </aside> ## GetSubaccount <a id="opIdGetSubaccount"></a> > Code samples...
Line range hint
188-188: Consider adding a missing white space near line 188.- true|none| |subaccountNumber|path|number(double)|true|none| > Example responses ... + true|none| |subaccountNumber|path|number(double)|true|none| > Example responses...
Line range hint
262-262: Consider correcting the possible spelling mistake found near line 262.- etf.org/html/rfc7231#section-6.3.1)|Ok|[SubaccountResponseObject](#schemasubaccountresponseobject)| <as... + ietf.org/html/rfc7231#section-6.3.1)|Ok|[SubaccountResponseObject](#schemasubaccountresponseobject)| <aside...
Line range hint
268-268: Consider correcting the possible spelling mistake found near line 268.- not require authentication </aside> ## GetParentSubaccount <a id="opIdGetParentSubaccount"></a> ... + not require authentication </aside> ## GetParentSubaccount <a id="opIdGetParentSubaccount"></a> > Code samples...
Line range hint
313-313: Consider adding a missing white space near line 313.- one| |parentSubaccountNumber|path|number(double)|true|none| > Example responses ... + one| |parentSubaccountNumber|path|number(double)|true|none| > Example responses...
Line range hint
395-395: Consider correcting the possible spelling mistake found near line 395.- etf.org/html/rfc7231#section-6.3.1)|Ok|[ParentSubaccountResponse](#schemaparentsubaccountresponse)| <as... + ietf.org/html/rfc7231#section-6.3.1)|Ok|[ParentSubaccountResponse](#schemaparentsubaccountresponse)| <aside...
Line range hint
401-401: Consider correcting the possible spelling mistake found near line 401.- not require authentication </aside> ## GetAssetPositions <a id="opIdGetAssetPositions"></a> > ... + not require authentication </aside> ## GetAssetPositions <a id="opIdGetAssetPositions"></a> > Code samples...
Line range hint
448-448: Consider adding a missing white space near line 448.- rue|none| |subaccountNumber|query|number(double)|true|none| > Example responses ... + rue|none| |subaccountNumber|query|number(double)|true|none| > Example responses...
Line range hint
472-472: Consider correcting the possible spelling mistake found near line 472.- etf.org/html/rfc7231#section-6.3.1)|Ok|[AssetPositionResponse](#schemaassetpositionresponse)| <aside... + ietf.org/html/rfc7231#section-6.3.1)|Ok|[AssetPositionResponse](#schemaassetpositionresponse)| <aside class="success">
Line range hint
478-478: Consider correcting the possible spelling mistake found near line 478.- not require authentication </aside> ## GetAssetPositionsForParentSubaccount <a id="opIdGetAssetPositionsForParentS... + not require authentication </aside> ## GetAssetPositionsForParentSubaccount <a id="opIdGetAssetPositionsForParentSubaccount"></a> > Code samples...
Line range hint
525-525: Consider adding a missing white space near line 525.- ne| |parentSubaccountNumber|query|number(double)|true|none| > Example responses ... + ne| |parentSubaccountNumber|query|number(double)|true|none| > Example responses...
Line range hint
549-549: Consider correcting the possible spelling mistake found near line 549.- etf.org/html/rfc7231#section-6.3.1)|Ok|[AssetPositionResponse](#schemaassetpositionresponse)| <aside... + ietf.org/html/rfc7231#section-6.3.1)|Ok|[AssetPositionResponse](#schemaassetpositionresponse)| <aside class="success">
Line range hint
555-555: Consider correcting the possible spelling mistake found near line 555.- not require authentication </aside> ## GetCandles <a id="opIdGetCandles"></a> > Code sa... + not require authentication </aside> ## GetCandles <a id="opIdGetCandles"></a> > Code samples...
Line range hint
602-602: Consider adding a missing white space near line 602.- solution)|true|none| |limit|query|number(double)|false|none| |fromISO|query|strin... + solution)|true|none| |limit|query|number(double)|false|none| |fromISO|query|string...
Line range hint
604-604: Consider correcting the possible spelling mistake found near line 604.- limit|query|number(double)|false|none| |fromISO|query|string|false|none| |toISO|query|s... + limit|query|number(double)|false|none| |fromISO|query|string|false|none| |toISO|query|string...
Line range hint
605-605: Consider correcting the possible spelling mistake found near line 605.- one| |fromISO|query|string|false|none| |toISO|query|string|false|none| #### Enumerat... + one| |fromISO|query|string|false|none| |toISO|query|string|false|none| #### Enumerated Values...
Line range hint
611-611: Consider adding a missing space between the number and word (or unit) near line 611.- |Parameter|Value| |---|---| |resolution|1MIN| |resolution|5MINS| |resolution|15MINS|... + |Parameter|Value| |---|---| |resolution|1 MIN| |resolution|5 MINS| |resolution|15 MINS|...
Line range hint
615-615: Consider adding a missing space between the number and word (or unit) near line 615.- 15MINS| |resolution|30MINS| |resolution|1HOUR| |resolution|4HOURS| |resolution|1DAY| ... + 15 MINS| |resolution|30 MINS| |resolution|1 HOUR| |resolution|4 HOURS| |resolution|1 DAY| ...
Line range hint
617-617: Consider adding a missing space between the number and word (or unit) near line 617.- |1HOUR| |resolution|4HOURS| |resolution|1DAY| > Example responses > 200 Response ... + |1 HOUR| |resolution|4 HOURS| |resolution|1 DAY| > Example responses > 200 Response ...
Line range hint
648-648: Consider correcting the possible spelling mistake found near line 648.- etf.org/html/rfc7231#section-6.3.1)|Ok|[CandleResponse](#schemacandleresponse)| <aside class=... + ietf.org/html/rfc7231#section-6.3.1)|Ok|[CandleResponse](#schemacandleresponse)| <aside class="success">
Line range hint
722-722: Consider correcting the possible spelling mistake found near line 722.- not require authentication </aside> ## GetFills <a id="opIdGetFills"></a> > Code samp... + not require authentication </aside> ## GetFills <a id="opIdGetFills"></a> > Code samples...
Line range hint
769-769: Consider adding a missing white space near line 769.- rue|none| |subaccountNumber|query|number(double)|true|none| |market|query|string|... + rue|none| |subaccountNumber|query|number(double)|true|none| |market|query|string...
Line range hint
771-771: Consider correcting the possible spelling mistake found near line 771.- none| |market|query|string|false|none| |marketType|query|[MarketType](#schemamarkettype)|f... + none| |market|query|string|false|none| |marketType|query|[MarketType](#schemamarkettype)|false|none| |limit|...
Line range hint
772-772: Consider adding a missing white space near line 772.- kettype)|false|none| |limit|query|number(double)|false|none| |createdBeforeOrAtHe... + kettype)|false|none| |limit|query|number(double)|false|none| |createdBeforeOrAtHeight...
Line range hint
773-773: Consider correcting the possible spelling mistake found near line 773.- limit|query|number(double)|false|none| |createdBeforeOrAtHeight|query|number(double)|false|none| |creat... + limit|query|number(double)|false|none| |createdBeforeOrAtHeight|query|number(double)|false|none| |createdBeforeOrAt...
Line range hint
773-773: Consider adding a missing white space near line 773.- e| |createdBeforeOrAtHeight|query|number(double)|false|none| |createdBeforeOrAt|q... + e| |createdBeforeOrAtHeight|query|number(double)|false|none| |createdBeforeOrAt|query...
Line range hint
774-774: Consider correcting the possible spelling mistake found near line 774.- eight|query|number(double)|false|none| |createdBeforeOrAt|query|[IsoString](#schemaisostring)|fal... + eight|query|number(double)|false|none| |createdBeforeOrAt|query|[IsoString](#schemaisostring)|false|none| #### En...
Line range hint
774-774: Consider correcting the possible spelling mistake found near line 774.- )|false|none| |createdBeforeOrAt|query|[IsoString](#schemaisostring)|false|none| #### En... + )|false|none| |createdBeforeOrAt|query|[IsoString](#schemaisostring)|false|none| #### Enumerated Values...
Line range hint
780-780: Consider correcting the possible spelling mistake found near line 780.- ed Values |Parameter|Value| |---|---| |marketType|PERPETUAL| |marketType|SPOT| > Example... + ed Values |Parameter|Value| |---|---| |marketType|PERPETUAL| |marketType|SPOT| > Example responses...
Line range hint
781-781: Consider correcting the possible spelling mistake found near line 781.- alue| |---|---| |marketType|PERPETUAL| |marketType|SPOT| > Example responses > 200 Respo... + alue| |---|---| |marketType|PERPETUAL| |marketType|SPOT| > Example responses > 200 Response...
Line range hint
814-814: Consider correcting the possible spelling mistake found near line 814.- etf.org/html/rfc7231#section-6.3.1)|Ok|[FillResponse](#schemafillresponse)| <aside class="s... + ietf.org/html/rfc7231#section-6.3.1)|Ok|[FillResponse](#schemafillresponse)| <aside class="success">
Line range hint
820-820: Consider correcting the possible spelling mistake found near line 820.- not require authentication </aside> ## GetFillsForParentSubaccount <a id="opIdGetFillsForParentSubaccount... + not require authentication </aside> ## GetFillsForParentSubaccount <a id="opIdGetFillsForParentSubaccount"></a> > Code samples...
Line range hint
867-867: Consider adding a missing white space near line 867.- ne| |parentSubaccountNumber|query|number(double)|true|none| |market|query|string|... + ne| |parentSubaccountNumber|query|number(double)|true|none| |market|query|string...
Line range hint
869-869: Consider correcting the possible spelling mistake found near line 869.- none| |market|query|string|false|none| |marketType|query|[MarketType](#schemamarkettype)|f... + none| |market|query|string|false|none| |marketType|query|[MarketType](#schemamarkettype)|false|none| |limit|...
Line range hint
870-870: Consider adding a missing white space near line 870.- kettype)|false|none| |limit|query|number(double)|false|none| |createdBeforeOrAtHe... + kettype)|false|none| |limit|query|number(double)|false|none| |createdBeforeOrAtHeight...
Line range hint
871-871: Consider correcting the possible spelling mistake found near line 871.- limit|query|number(double)|false|none| |createdBeforeOrAtHeight|query|number(double)|false|none| |creat... + limit|query|number(double)|false|none| |createdBeforeOrAtHeight|query|number(double)|false|none| |createdBeforeOrAt...
| import * as Knex from 'knex'; | ||
|
|
||
| export async function up(knex: Knex): Promise<void> { | ||
| return knex.schema.raw(` |
There was a problem hiding this comment.
nit: Can use this function instead, which changes the constraints w/o locking the table.
Non-blocking as the version with this table isn't released yet.
|
https://github.com/Mergifyio backport release/indexer/v5.x |
✅ Backports have been created
|
(cherry picked from commit 37d99ef)
|
https://github.com/Mergifyio backport release/indexer/v5.x |
✅ Backports have been created
|
|
https://github.com/Mergifyio backport release/indexer/v5.x |
✅ Backports have been created
|
Changelist
Context: If a previously compliant user connects from a geo-restricted country, they will first be put into FIRST_STRIKE_CLOSE_ONLY. They will then receive a survey where they will answer their place of residence. Based on their response, they can transition from FIRST_STRIKE_CLOSE_ONLY -> (FIRST_STRIKE, CLOSE_ONLY).
Test Plan
Unit tested.
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.Summary by CodeRabbit
Summary by CodeRabbit