move e2e test app instantiation to Build

[jayy04]

Changelist

• so that we can modify state before InitChain is called

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

[coderabbitai]

Walkthrough

The update primarily involves renaming the receiver variable from tApp to builder in the TestAppBuilder struct methods to enhance clarity. This renaming spans across methods that manage health monitoring, non-determinism checks, and crash-related checks. Additionally, the Build method has been refined to initialize a TestApp instance more effectively by setting an initialized flag.

Changes

File	Change Summary
protocol/.../app/app.go	Renamed receiver variable in TestAppBuilder methods from tApp to builder. Updated Build method to set initialized flag in TestApp.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 15512b1 and 1c9fd8f.

Files selected for processing (1)

• protocol/testutil/app/app.go (8 hunks)

Additional Context Used

Path-based Instructions (1)

protocol/testutil/app/app.go (1)

Pattern **/**: Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.

Additional comments not posted (5)

protocol/testutil/app/app.go (5)

359-361: Renaming the receiver variable from tApp to builder improves clarity and consistency across the methods.

---

371-373: Renaming the receiver variable from tApp to builder improves clarity and consistency across the methods.

---

385-388: Renaming the receiver variable from tApp to builder improves clarity and consistency across the methods.

---

392-396: Renaming the receiver variable from tApp to builder improves clarity and consistency across the methods.

---

Line range hint 400-567: The changes in the Build method include setting an initialized flag and handling initialization checks. This is a crucial update for ensuring that the app initialization is performed only once, which enhances the robustness of the test setup.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jayy04]

@Mergifyio backport release/protocol/v5.x

[mergify]

backport release/protocol/v5.x

✅ Backports have been created

• #1440 move e2e test app instantiation to Build (backport #1422) has been created for branch release/protocol/v5.x