Add QueryAllLiquidityTiers to CLI
#1434
Conversation
|
@Mergifyio backport release/protocol/v5.x |
✅ Backports have been created
|
|
Warning Rate Limit Exceeded@teddyding has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 9 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe update introduces a new command Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
protocol/x/perpetuals/client/cli/query_all_liquidity_tiers.go (1)
12-33: The implementation ofCmdQueryAllLiquidityTiersfollows standard practices for Cobra command definitions and interacts correctly with the Cosmos SDK client. Good use of context and proper error handling.However, consider adding more detailed documentation for the command, explaining what data it retrieves and any potential use cases or limitations.
| func TestAllLiquidityTiers(t *testing.T) { | ||
| net, _, _ := networkWithLiquidityTierAndPerpetualObjects(t, 2, 2) | ||
| ctx := net.Validators[0].ClientCtx | ||
|
|
||
| common := []string{fmt.Sprintf("--%s=json", tmcli.OutputFlag)} | ||
|
|
||
| out, err := clitestutil.ExecTestCLICmd(ctx, cli.CmdQueryAllLiquidityTiers(), common) | ||
| require.NoError(t, err) | ||
|
|
||
| var resp types.QueryAllLiquidityTiersResponse | ||
| require.NoError(t, net.Config.Codec.UnmarshalJSON(out.Bytes(), &resp)) | ||
| require.Equal(t, 2, len(resp.LiquidityTiers)) | ||
| } |
There was a problem hiding this comment.
The test TestAllLiquidityTiers correctly sets up a network context and checks the command's output. It validates the expected number of liquidity tiers, ensuring the command's functionality.
Consider adding additional test cases to cover error scenarios, such as what happens if the network or query fails.
Changelist
[Describe or list the changes made in this PR]
Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.