fix: Fix v5 upgrade VE handler #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
approved these changes
May 6, 2024
davidterpay
approved these changes
May 6, 2024
teddyding
reviewed
May 6, 2024
| panic(fmt.Sprintf("failed to retrieve existing consensus params in VE upgrade handler: %s", err)) | ||
| } | ||
| if currentParams.Params.Abci.VoteExtensionsEnableHeight != 0 { | ||
| if currentParams.Params.Abci != nil && currentParams.Params.Abci.VoteExtensionsEnableHeight != 0 { |
There was a problem hiding this comment.
Looks like currentParams.Params.Abci is never read and we just initialize it below. Should we just remove this code block?
There was a problem hiding this comment.
The reason I initially put it in there is because if you've already set a VE enable height that's nonzero it's unknown (to me at least) what happens if you update that again.
Happy to remove it since we assume this will be run once ever.
Christopher-Li
approved these changes
May 6, 2024
|
@mergify backport release/protocol/v5.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 6, 2024
* Add nil protections on upgrade handler * Fix import name * Address comment (cherry picked from commit 5e002ee)
6 tasks
teddyding
pushed a commit
that referenced
this pull request
May 6, 2024
jonfung-dydx
pushed a commit
that referenced
this pull request
May 6, 2024
* Add nil protections on upgrade handler * Fix import name * Address comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Add protections around nil VE ABCI Params
Test Plan
Send to a single validator first on testnet.
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.