Update iavl with WorkingHash fix #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddyding
reviewed
May 9, 2024
protocol/go.mod
Outdated
| @@ -432,7 +432,7 @@ replace ( | |||
| github.com/cometbft/cometbft => github.com/dydxprotocol/cometbft v0.38.6-0.20240426214049-c8beeeada40a | |||
| // Use dYdX fork of Cosmos SDK | |||
| github.com/cosmos/cosmos-sdk => github.com/dydxprotocol/cosmos-sdk v0.50.6-0.20240326192503-dd116391188d | |||
| github.com/cosmos/iavl => github.com/dydxprotocol/iavl v1.1.1-0.20240408175732-0fca9d69cbc4 | |||
| github.com/cosmos/iavl => github.com/dydxprotocol/iavl v1.1.1-0.20240509160433-4cb59900bfb2 | |||
There was a problem hiding this comment.
Question on the underlying iavl fork commit: instead of allowing roy/* should we specify roy/v1.x.x-fix instead to not push future test commits
There was a problem hiding this comment.
Doesn't matter. Rule only applies for the branch itself.
There was a problem hiding this comment.
Ok, we don't plan to continue managing the our iavl fork right? We are just using this commit for the WorkingHash fix
|
The commit dydxprotocol/iavl@4cb59900bfb2 is failing tests. I don't think this is expected. |
vincentwschau
approved these changes
May 9, 2024
|
@Mergifyio backport release/protocol/v5.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 9, 2024
(cherry picked from commit 711ae63)
6 tasks
roy-dydx
added a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
WorkingHash was computed incorrectly for trees that are initialized with an InitialVersion. This happens when a new store is introduced in an upgrade. If the store is empty, the hash ends up being the same anyways so the bug only manifests when the store has values at the upgrade height.
See dydxprotocol/iavl@1c8b8e7.
Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.