Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iavl with WorkingHash fix (backport #1484) #1487

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 9, 2024

Changelist

WorkingHash was computed incorrectly for trees that are initialized with an InitialVersion. This happens when a new store is introduced in an upgrade. If the store is empty, the hash ends up being the same anyways so the bug only manifests when the store has values at the upgrade height.

See dydxprotocol/iavl@1c8b8e7.

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

This is an automatic backport of pull request #1484 done by [Mergify](https://mergify.com).

@mergify mergify bot mentioned this pull request May 9, 2024
6 tasks
@roy-dydx roy-dydx merged commit eee8f67 into release/protocol/v5.x May 9, 2024
11 checks passed
@roy-dydx roy-dydx deleted the mergify/bp/release/protocol/v5.x/pr-1484 branch May 9, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant