Stop passing in app PreBlocker to slinky VE handler #1491
Conversation
|
Warning Rate Limit Exceeded@roy-dydx has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 38 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent update involves modifying the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
protocol/app/app.go (1)
Line range hint
740-740: Secure the gRPC server by adding SSL/TLS credentials.- grpc.NewServer(), + grpc.NewServer(grpc.Creds(credentials.NewServerTLSFromFile("cert.pem", "cert.key"))),
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- protocol/app/app.go (1 hunks)
Additional Context Used
Path-based Instructions (1)
protocol/app/app.go (1)
Pattern
**/**: Do not include a walkthrough. For all comments on line changes that are longer than 15 lines, add a prefix to the comment of what lines you are commenting on (for example: "The changes from lines 100 to 200...". Add your comment to be on the last 15 lines of the chunk rather than adding your comment to the entire chunk.
protocol/app/app.go
Outdated
| // We are not using the slinky PreBlocker, so there is no need to pass in PreBlocker here. | ||
| // Currently, the clob PreBlocker assumes that it will only be called during the normal ABCI | ||
| // PreBlocker step, so passing in the app PreBlocker will cause issues. | ||
| func(_ sdk.Context, _ *abci.RequestFinalizeBlock) (*sdk.ResponsePreBlock, error) { | ||
| return nil, nil | ||
| }, |
There was a problem hiding this comment.
Remove unnecessary comments about PreBlocker since it's no longer used here.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| // We are not using the slinky PreBlocker, so there is no need to pass in PreBlocker here. | |
| // Currently, the clob PreBlocker assumes that it will only be called during the normal ABCI | |
| // PreBlocker step, so passing in the app PreBlocker will cause issues. | |
| func(_ sdk.Context, _ *abci.RequestFinalizeBlock) (*sdk.ResponsePreBlock, error) { | |
| return nil, nil | |
| }, | |
| func(_ sdk.Context, _ *abci.RequestFinalizeBlock) (*sdk.ResponsePreBlock, error) { | |
| return nil, nil | |
| }, |
(cherry picked from commit 2494557)
Changelist
Slinky and clob both depend on invariants of preblocker, but they violate each other's assumptions. Slinky assumes that preblocker only mutates the context it's passed, so it's safe to use it on a cached context. Clob assumes preblocker is only called during the normal abci path, so it uses mutates state kept in the clobkeeper instance to ensure it's only called once ever.
The quickest fix is to just stop calling app PreBlocker in slinky VE handler.
Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.Summary by CodeRabbit