-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
locator-directory should not return empty string #1470
Labels
Comments
cgay
added a commit
to cgay/opendylan
that referenced
this issue
Jan 15, 2023
It doesn't make sense for a relative directory locator to have an empty directory path. (But it does make sense for an absolute directory locator, in which case it represents the root directory.) Fixes dylan-lang#1470
cgay
added a commit
to cgay/opendylan
that referenced
this issue
Jan 15, 2023
It doesn't make sense for a relative directory locator to have an empty directory path. (But it does make sense for an absolute directory locator, in which case it represents the root directory.) Fixes dylan-lang#1470
cgay
added a commit
to cgay/opendylan
that referenced
this issue
Jan 15, 2023
It doesn't make sense for a relative directory locator to have an empty directory path. (But it does make sense for an absolute directory locator, in which case it represents the root directory.) Fixes dylan-lang#1470
cgay
added a commit
to cgay/opendylan
that referenced
this issue
Mar 29, 2023
It doesn't make sense for a relative directory locator to have an empty directory path. (But it does make sense for an absolute directory locator, in which case it represents the root directory.) Fixes dylan-lang#1470
cgay
added a commit
to cgay/opendylan
that referenced
this issue
Apr 8, 2024
It doesn't make sense for a relative directory locator to have an empty directory path. (But it does make sense for an absolute directory locator, in which case it represents the root directory.) Fixes dylan-lang#1470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think it should be valid to do
ensure-directory-exists(relative-path)
. While fixing dylan-lang/testworks#157 I wrote this test:test-temp-directory
makes a relative path because I've setDYLAN
that way, and then callsensure-directories-exist
with it, which ends up with the following error because locator-directory returns the empty string.The text was updated successfully, but these errors were encountered: