Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all Characters from Up-Stream #6

Closed
dylhack opened this issue Aug 8, 2023 · 0 comments · Fixed by #9
Closed

Support all Characters from Up-Stream #6

dylhack opened this issue Aug 8, 2023 · 0 comments · Fixed by #9
Labels
bug Something isn't working

Comments

@dylhack
Copy link
Owner

dylhack commented Aug 8, 2023 •
edited
Loading

The chop function is currently written around the support of 256-bit colors. The characters commented out utilize RGB, which currently isn't supported.

https://github.com/dylhack/cowsay-bot/blob/658769b510a0351a4d1d605a9fb5026a7804a38d/src/cowsay.rs#L5-L32
@dylhack dylhack added the bug Something isn't working label Aug 8, 2023
@dylhack dylhack linked a pull request Aug 21, 2023 that will close this issue
#6: Support all Characters from Up-Stream #9
Merged
@dylhack dylhack mentioned this issue Aug 21, 2023
Merged
dylhack added a commit that referenced this issue Aug 21, 2023
@dylhack
#6: Support all Characters from Up-Stream (#9)
66eea25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#6: Support all Characters from Up-Stream dylhack/cowsay
1 participant
@dylhack