Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: avoid initializing dylibso_observe module multiple times #147

Merged
merged 1 commit into from
Dec 1, 2023
Merged

cleanup: avoid initializing dylibso_observe module multiple times #147

merged 1 commit into from
Dec 1, 2023

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Dec 1, 2023 •
edited
Loading

Avoid adding the dylibso_observe functions multiple times, fixes an issue we're running into in: bacalhau-project/bacalhau#2971

nilslice
nilslice approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@nilslice nilslice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GREAT CATCH!!

@zshipko zshipko merged commit 141351c into main Dec 1, 2023
6 checks passed
@zshipko zshipko deleted the avoid-double-init branch December 1, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilslice nilslice nilslice approved these changes

@wikiwong wikiwong wikiwong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zshipko @wikiwong @nilslice