New Wellington Colours #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please use a better name |
|
This fixes #118 |
mjdavidson
approved these changes
Jul 15, 2018
mjdavidson
requested changes
Jul 15, 2018
server-worker/lines/nz-wlg.js
Outdated
| @@ -178,47 +76,64 @@ const sortLines = (lines) => { | |||
| } | |||
| return parsedA - parsedB | |||
| } | |||
| lines.forEach((i) => { | |||
| lines.forEach(i => { | |||
There was a problem hiding this comment.
please use a more descriptive iterator
There was a problem hiding this comment.
something like lines.foreach(line => { would be preferable
mjdavidson
requested changes
Jul 15, 2018
| } else { | ||
| lineGroups[regionEnum.central].items.push(record.route_short_name) | ||
| if (record.route_short_name.slice(0, 1) === 'N') { |
There was a problem hiding this comment.
would like some line comments to know what you're trying to achieve by this slice
There was a problem hiding this comment.
Checks if the first character is N?
mjdavidson
approved these changes
Jul 15, 2018
consindo
pushed a commit
that referenced
this pull request
May 9, 2019
* Add protobufjs * Remove console.log() * Fix colors! * Compress Sydney SVG * Add more double deckers * Clean Up Desktop Design * Modular iOS Back Swipe * Switch to SVG Icons * iOS Fixes * Fix Trains not showing up * Significantly Improve Root Card Performance * Improve Map Performance * Add Smooth Scrolling Polyfill * Fix Timetable * Update package.json links and version * Update homepage * Add apidoc * Add more API Documentation * Complete Documentation of Stations * Finish API Documentation * Move Azure Storage Methods into Class * Worker Heartbeat * Move Headsign Calculation Server - #94 * Fix Dynamic Icons Firefox * Fix Wellington Route Direction - #83 * Fix Multistop Timetables & Maps * Fix #100 - Add New Eastern Network * #63 - Timetable for Multiple Days * Remove 580, add 70H for nz-akl, add "Pick City" * Add extra stop times index * Add Parking Building Locations to Auckland * Show Parking Occupancy in Station Description * Show Parking Rates on Open * Prevent Saving of Parking Buildings * Initial Otago GTFS * Add Otago Lines Listing * Add Ronwood St Carpark & Improve Stop Labelling * Add Ōtepoti & Tāhuna to City Picker * Support Prefixed Lines Lookup * Update Private UI To Support Adding Workers * Fix Thousands of Minutes Away Bug * Support for Custom Coloring Functions (Queenstown) * Add Basic Terraform & Docker Config * Improve Region Popover * Add S3 support to storage.js * Set the position on page load to be the station * Discard Order on Desktop * Sign Mode - Show Two Stations * Fix Wellington Realtime & Add Auto Refresh * Add Marketing * add react-native-web * Start Cleaning Up Root Shell * Start of Apple Maps Style UI * Use Better UI for Default Header * initial onzo proxy through server * Add Shell Card Default Animations * Add Additional Snap Point * Fix Flicks * Fix Scroll Rejection & Toggle Stations Button * Fix Remounting, Add Sticky Headers * Remove Main Header, Add Map Padding, Perfomance * Improve DB performance * Modified identity key (id) to be non-clustered * Added clustered indexes on semantic key columns * Added non-clustered indxes on columns included in JOIN/WHERE clauses * Improved naming convention of index names * changing how onzo is sent new query param bikes=true will trigger onzo to be sent * Kind of working scroll * Linked Scroll Component * Port Sponsor Page to RN + New UI * Add Pull Indicator to Header * Distinguish Between Back & Forward * Always Draggable Header + Touch Action Fix * change order of args * return onzos * show bikes * change bike to black * put a custom view for onzo * upgrade onzo to rnw * check for ev tag and add bool (#111) * check for ev tag and add bool * indexof * change to includes * Add Max -> Default Animation * Add Max -> Max Entering and Exiting Animation * Add Default -> Max Animation * Move Region Picker to New UI * Port NoMatch to new UI * Remove Sign Mode * Port Station Component to RNW * Upgrade React * Remove Majority of Deprecated React Methods * turn off bikes (#114) * Fix Some Scrolling Bugs * change eq * Ensure Correct Back & Forward Animations * Fade Between Stations - Replace State * Performance Improvements for Scrolling & Flicking * Speed Improvements Approx 1/3rd Speedup - 150ms to 100ms. Still too slow! * Fast Switch Component * Add Animation Support to Switch Component * Fix Header Pull Issue + Fix Bundle Size * Improve Scrolling Container * Implement Hacked TouchableOpacity * Move AKL Test Lines Component to Integration Test * Add Curve to Card * update some new routes * removed all existing routes this commit only has new central routes * Larger Headers * Add Additional Icon to Header * Move Timetable to New UI * Remove Search Modal & Button * Move Locate Button * Add Settings to New UI * Fix Small Papercuts Auto Scrolling on tap in the Station View iOS Scroll Min Height set to 101% Settings Fix Weird Padding Fix Race Condition on Pulling Down on Card and Incorrect Animation * Initial Desktop Styles * Desktop Design * Move Desktop Changes to Pure CSS * Add Desktop Animations * Fix Papercuts iOS Animation Jump Increase Touch Targets for Close Fix Search Icon * Port Save to New UI (Design TBD) * Style Save UI * Enable Mobile Use with Mouse * Restructure Map Files * Move Line Data to Data Access File * Basic GeoJSON Layer * Colored GeoJSON fitting to map * Fix iPhone X Inset and Flicker on Link Button * Basic Points Layer * Fixed SQL query for stop/route search * Correct zIndex of SVG + Stops Toggle * Re-Add Legacy Popups * Add New Line Stops View * central new network * tamaki link * remove console * Add Basic Live Line Component * fix color picker * fix formatting of lines * Display Live Location * Remove Old Vehicle Location View * fixed all names to pass tests * fix 309x * Fix Flickering on Lines & Services * Fix Flicking on Root View * Remove Server Static * Fix Broken Build * Add Darken Animation for iOS * Fix Small Bugs MapView not moving map StartWatch Timeout Carpark Styles * missing routes * new tests * Get Colors from Database for Wellington (#122) * Fix #123: Wellington Headsign (#127) * Fix Wellington Headsign * Reduce Importer Duplication * Improve City Integrations (#129) * Initial Christchurch GTFS Import * Reduce Duplication of Lines Code * Map Missing Stop Codes to Stop_ID * Move Importers * Add Christchurch Lines & Colors * Add Bounds to Info Endpoint * Endpoint for Available Regions * Location Filter for Auckland Carparks * Automatic Bounds Mapping * Christchurch Line Groups * Add More Data to Regions & Lines Endpoints * Move document.title to Header Component * Pull Cities from Server, instead of Hardcode * Remove Local GetCity Code * Update API Documentation * Add route_icon support * Add Christchurch Route Icons * Add Auckland Metro Congestion Free Icons * Add Christchurch Icons * Add Auckland Route Icons * Add SkyBus Logo (disabled) * Add license scan report and status Signed-off-by: fossabot <badges@fossa.io> * Switch to new DYMAJO Maps * Fix Code Style Issues * Port Shapes to AWS * Prevent Server from Crashing on 404 * Fix Key Names * Prevent S3 Errors from Crashing App * Update CORS Config * Add Git Attributes * Normalize all the line endings * Prevent Map from Moving to (0,0) * Add Dockerfile * Add Travis Config * Upload Static Files to S3 * Remove Duplicate Keys in nz-akl lines * Update Lines for North Shore New Network * Move Dockerfile * Getting All Routes for Station * Return Trip Headsign in All Routes Call * Move Stops SQL to DataAccess File * Updated getRoutesForStop SQL query * eslint change *adding some rules to give a bit more of a uniform style *contentious ones: ** prefer await ** airbnb ** no unused vars ** comma-dangle * Fix Wellington Version with Space * Store Realtime Last Update * Add Realtime Healthcheck Endpoint * Fixes for Node 8 * Add Transfers to Route Stops Lookup * Add Transfers to Line Stops View * Fix Wellington Bad Stops Error * Add Realtime Location V2 Endpoint * Support new Realtime Location V2 in Auckland * Show Realtime Vehicle Info on Lines Page * Add Error Handling to Lines Page * Remove Old Live Lines Page * Add Documentation for New Endpoint * Make sure line is not disposed. * Use Native Add to Home Screen if Available * Add TWA for Android App * fix au-syd icons * make all class/jsx TitleCase and export default * renege matt's changes
consindo
added a commit
that referenced
this pull request
Jun 14, 2019
* Add protobufjs * Remove console.log() * Fix colors! * Compress Sydney SVG * Add more double deckers * Clean Up Desktop Design * Modular iOS Back Swipe * Switch to SVG Icons * iOS Fixes * Fix Trains not showing up * Significantly Improve Root Card Performance * Improve Map Performance * Add Smooth Scrolling Polyfill * Fix Timetable * Update package.json links and version * Update homepage * Add apidoc * Add more API Documentation * Complete Documentation of Stations * Finish API Documentation * Move Azure Storage Methods into Class * Worker Heartbeat * Move Headsign Calculation Server - #94 * Fix Dynamic Icons Firefox * Fix Wellington Route Direction - #83 * Fix Multistop Timetables & Maps * Fix #100 - Add New Eastern Network * #63 - Timetable for Multiple Days * Remove 580, add 70H for nz-akl, add "Pick City" * Add extra stop times index * Add Parking Building Locations to Auckland * Show Parking Occupancy in Station Description * Show Parking Rates on Open * Prevent Saving of Parking Buildings * Initial Otago GTFS * Add Otago Lines Listing * Add Ronwood St Carpark & Improve Stop Labelling * Add Ōtepoti & Tāhuna to City Picker * Support Prefixed Lines Lookup * Update Private UI To Support Adding Workers * Fix Thousands of Minutes Away Bug * Support for Custom Coloring Functions (Queenstown) * Add Basic Terraform & Docker Config * Improve Region Popover * Add S3 support to storage.js * Set the position on page load to be the station * Discard Order on Desktop * Sign Mode - Show Two Stations * Fix Wellington Realtime & Add Auto Refresh * Add Marketing * add react-native-web * Start Cleaning Up Root Shell * Start of Apple Maps Style UI * Use Better UI for Default Header * initial onzo proxy through server * Add Shell Card Default Animations * Add Additional Snap Point * Fix Flicks * Fix Scroll Rejection & Toggle Stations Button * Fix Remounting, Add Sticky Headers * Remove Main Header, Add Map Padding, Perfomance * Improve DB performance * Modified identity key (id) to be non-clustered * Added clustered indexes on semantic key columns * Added non-clustered indxes on columns included in JOIN/WHERE clauses * Improved naming convention of index names * changing how onzo is sent new query param bikes=true will trigger onzo to be sent * Kind of working scroll * Linked Scroll Component * Port Sponsor Page to RN + New UI * Add Pull Indicator to Header * Distinguish Between Back & Forward * Always Draggable Header + Touch Action Fix * change order of args * return onzos * show bikes * change bike to black * put a custom view for onzo * upgrade onzo to rnw * check for ev tag and add bool (#111) * check for ev tag and add bool * indexof * change to includes * Add Max -> Default Animation * Add Max -> Max Entering and Exiting Animation * Add Default -> Max Animation * Move Region Picker to New UI * Port NoMatch to new UI * Remove Sign Mode * Port Station Component to RNW * Upgrade React * Remove Majority of Deprecated React Methods * turn off bikes (#114) * Fix Some Scrolling Bugs * change eq * Ensure Correct Back & Forward Animations * Fade Between Stations - Replace State * Performance Improvements for Scrolling & Flicking * Speed Improvements Approx 1/3rd Speedup - 150ms to 100ms. Still too slow! * Fast Switch Component * Add Animation Support to Switch Component * Fix Header Pull Issue + Fix Bundle Size * Improve Scrolling Container * Implement Hacked TouchableOpacity * Move AKL Test Lines Component to Integration Test * Add Curve to Card * update some new routes * removed all existing routes this commit only has new central routes * Larger Headers * Add Additional Icon to Header * Move Timetable to New UI * Remove Search Modal & Button * Move Locate Button * Add Settings to New UI * Fix Small Papercuts Auto Scrolling on tap in the Station View iOS Scroll Min Height set to 101% Settings Fix Weird Padding Fix Race Condition on Pulling Down on Card and Incorrect Animation * Initial Desktop Styles * Desktop Design * Move Desktop Changes to Pure CSS * Add Desktop Animations * Fix Papercuts iOS Animation Jump Increase Touch Targets for Close Fix Search Icon * Port Save to New UI (Design TBD) * Style Save UI * Enable Mobile Use with Mouse * Restructure Map Files * Move Line Data to Data Access File * Basic GeoJSON Layer * Colored GeoJSON fitting to map * Fix iPhone X Inset and Flicker on Link Button * Basic Points Layer * Fixed SQL query for stop/route search * Correct zIndex of SVG + Stops Toggle * Re-Add Legacy Popups * Add New Line Stops View * central new network * tamaki link * remove console * Add Basic Live Line Component * fix color picker * fix formatting of lines * Display Live Location * Remove Old Vehicle Location View * fixed all names to pass tests * fix 309x * Fix Flickering on Lines & Services * Fix Flicking on Root View * Remove Server Static * Fix Broken Build * Add Darken Animation for iOS * Fix Small Bugs MapView not moving map StartWatch Timeout Carpark Styles * missing routes * new tests * Get Colors from Database for Wellington (#122) * Fix #123: Wellington Headsign (#127) * Fix Wellington Headsign * Reduce Importer Duplication * Improve City Integrations (#129) * Initial Christchurch GTFS Import * Reduce Duplication of Lines Code * Map Missing Stop Codes to Stop_ID * Move Importers * Add Christchurch Lines & Colors * Add Bounds to Info Endpoint * Endpoint for Available Regions * Location Filter for Auckland Carparks * Automatic Bounds Mapping * Christchurch Line Groups * Add More Data to Regions & Lines Endpoints * Move document.title to Header Component * Pull Cities from Server, instead of Hardcode * Remove Local GetCity Code * Update API Documentation * Add route_icon support * Add Christchurch Route Icons * Add Auckland Metro Congestion Free Icons * Add Christchurch Icons * Add Auckland Route Icons * Add SkyBus Logo (disabled) * Add license scan report and status Signed-off-by: fossabot <badges@fossa.io> * Switch to new DYMAJO Maps * Fix Code Style Issues * Port Shapes to AWS * Prevent Server from Crashing on 404 * Fix Key Names * Prevent S3 Errors from Crashing App * Update CORS Config * Add Git Attributes * Normalize all the line endings * Prevent Map from Moving to (0,0) * Add Dockerfile * Add Travis Config * Upload Static Files to S3 * Remove Duplicate Keys in nz-akl lines * Update Lines for North Shore New Network * Move Dockerfile * Getting All Routes for Station * Return Trip Headsign in All Routes Call * Move Stops SQL to DataAccess File * Updated getRoutesForStop SQL query * eslint change *adding some rules to give a bit more of a uniform style *contentious ones: ** prefer await ** airbnb ** no unused vars ** comma-dangle * Fix Wellington Version with Space * Store Realtime Last Update * Add Realtime Healthcheck Endpoint * Fixes for Node 8 * Add Transfers to Route Stops Lookup * Add Transfers to Line Stops View * Fix Wellington Bad Stops Error * Add Realtime Location V2 Endpoint * Support new Realtime Location V2 in Auckland * Show Realtime Vehicle Info on Lines Page * Add Error Handling to Lines Page * Remove Old Live Lines Page * Add Documentation for New Endpoint * Make sure line is not disposed. * Use Native Add to Home Screen if Available * Add TWA for Android App * fix au-syd icons * make all class/jsx TitleCase and export default * renege matt's changes * add local server * make au-syd work * Return Bus if Route Type is Unknown * Fix Realtime Map Icons * Revert Trigger Map Button * add dodgy all vehicle view * add other icon types * change to map from array for icon helper * use short route name for sydney trains * Fix Icons (again) * Remove
mjdavidson
pushed a commit
that referenced
this pull request
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.